Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review all new FC_ASSERT added to next milestone #678

Closed
abitmore opened this issue Feb 19, 2018 · 2 comments
Closed

Review all new FC_ASSERT added to next milestone #678

abitmore opened this issue Feb 19, 2018 · 2 comments
Labels
security
Milestone
201803 Non-Consen...

Comments

@abitmore
Copy link
Member

Review new added FC_ASSERT, to make sure they won't break consensus, nor have the possibility to halt the chain unexpectedly.
@abitmore abitmore added this to the Next Non-Consensus-Changing Release milestone Feb 19, 2018
@abitmore
Copy link
Member Author

So far so good.

At a glance, the only one change is c2d28be, but it should be safe.

Will review again when new pull requests got merged.

@abitmore
Copy link
Member Author

Done.

@xeroc xeroc mentioned this issue Jan 8, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
security
Projects
None yet
Milestone
201803 Non-Consensus-Changing Release
Development

No branches or pull requests
1 participant
@abitmore