-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
osx witness node crash when place order #582
Comments
If it's Ubuntu, I will run the node in gdb, trigger a segmentation fault, then get the output of |
please find the log below for your further investigation ,thanks
|
Thanks for the report. Still not sure why it happened, but hopefully it won't happen again after #468 is done. |
Perhaps related to steemit/steem#2076 |
@crazybits can you check if the PR steemit/steem#2077 will fix this issue? |
i'm also seeing this issue on OS X any time an order is created or canceled, or a withdrawal is initiated using the crypto-bridge client when it's pointed at my local node, i get a segfault... |
@cphrmky @crazybits can you check whether #661 fixes/gets-around this issue? Thanks. |
I tested this on my mac with the develop and main branch, pointing to my testnet, and could not recreate the problem. Either (1) the problem has been fixed, or (2) my configuration is different, or (3) it only happens on the mainnet (which in my mind is improbable and would take a long time to for me to test). My guess is (1). If this is still happening for someone, please provide me with more information and I'll take another look. I need the versions of OS, Boost, OpenSSL, and bitshares-core commit. |
@jmjatlanta try mainnet please. Thanks. |
Macbook Pro running High Sierra (10.13.3) The witness_node is running locally, started as: I was able to create an order (limit order, STEALTH to BTS) without causing the witness node to crash. Please post your setup, and any details on how to recreate the issue, and I will attempt to figure out the cause. Thanks. |
@jmjatlanta can you public your macOS binaries of the latest release? Then we can get some people to help test. For example, upload to your github repo. |
The binaries can be found here: |
@jmjatlanta got a report when running
Seems need to statically link those libs? |
Looking at the cmake files, it looks as if tcmalloc is optional. I have compiled without it. See the appropriate binaries at https://github.com/jmjatlanta/bitshares-core/releases/tag/mac-2.0.180226 |
@jmjatlanta I got a report that the replay speed of new |
I'll attempt a static link of tcmalloc libraries, and then they can do a comparison. A comparison on my mac would be close to meaningless, as its resources are strained. I'll update here when the libraries are uploaded. |
It's not likely, but worth mentioning: make sure the binaries are not built in |
The statically linked binaries are available at https://github.com/jmjatlanta/bitshares-core/releases/tag/mac-2.0.180226. Let me know how it goes. BTW: none of these were with the DEBUG flag set. |
IIRC debug mode is default. I always run |
Ok. I'll recompile with explicitly naming the build type. Coming soon... |
@jmjatlanta I got report that your binaries crash as well, exactly as @cphrmky said:
By the way, I believe the develop branch won't crash due to #661. So it would help if you could provide binaries built from develop branch. Thank you very much. |
@jmjatlanta I just noticed one thing: others crashed witness_node via light wallet but not cli_wallet. |
Ahhh. I was testing with the cli_wallet. I've provided binaries with tcmalloc statically linked for both the master branch and develop, and will now test them myself with the light wallet. Sorry for the slow response, as I'm fighting the flu with all I've got. |
ping when you've got the statically linked binaries up, happy to download and see if it's still happening |
They're there. https://github.com/jmjatlanta/bitshares-core/releases/tag/mac-2.0.180226 |
My first attempt to sync on OS X ran fine up to a point, that at some block or other it just hung forever. By "forever" I mean multiple days of not moving beyond that one block. Despite politely killing the process and restarting, brutally killing the process, restarting the computer, switching to multiple different network connections, etc. Eventually I just did I've seen basically this exact same behavior with unrelated chains, always on OS X. I've had it happen when syncing a full Ethereum node to a Mac using geth (more than one Mac). I've had it happen when syncing Electroneum (which is a fork of Monero) to a Mac. If this syncing is the actually the same issue across these different projects (it could be straight coincidental) it the data would point to an issue with the the mac implementation of some c++ lib they all have in common. |
@jmjatlanta the binaries you provided are not actually static linked with tcmalloc, as it still reports "dyld: Library not loaded" errors again. I think the |
No matter what I tell (or don't tell) cmake, it seems to always want to use the dynamic libraries. I'm going to delete the shared libraries, and see what it decides to do then (fly meet sledgehammer)! In the meantime, I compiled the develop branch without tcmalloc and in Release mode. Those files are available at the usual spot. https://github.com/jmjatlanta/bitshares-core/releases/tag/mac-2.0.180226 I was able to replicate the issue placing a simple order using the light client and the master branch. Using the build without tcmalloc and the develop branch, my mac slowed to a crawl before the chain was sync'd. Now trying the tcmalloc version... |
Develop branch, using the light client, canceled an order, segfault.
|
So #661 didn't help. It's strange. Can you try get a backtrace? Check the 2nd and 3rd comments in this issue. By the way I think priority of this issue if not very high (removed from next milestone), perhaps put it aside if it's too hard or takes too much time. |
@jmjatlanta I guess #813 will fix this issue. Can you help check? Perhaps make a new binary with the patch so other people can help test. |
@jmjatlanta please close this issue if can confirm it's fixed by #813. |
Assuming that #813 fixed this issue. Closing. Please feel free to reopen if it's not the case. |
osx witness node crash when place order, above is the only log in console, any infor is required, please let me know.
The text was updated successfully, but these errors were encountered: