Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Witness nodes sometimes accept transactions with unnecessary signatures #580

Open
abitmore opened this issue Jan 14, 2018 · 1 comment
Open

Comments

@abitmore
Copy link
Member

abitmore commented Jan 14, 2018

As described in #197 (comment), when an operation requires owner permission, if a transaction contains that operation is signed by both active key and owner key (two signatures), it will still be accepted by witness nodes. But actually the signature signed by the active key is unnecessary.

To "fix" this, need to change the consensus. It's tricky because it requires client applications to adapt to the new rule, so it's possible to break some of them.

Update: test case is here: fbef6c2

@abitmore
Copy link
Member Author

Added test case in fbef6c2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant