Check transaction size

[abitmore]

Bug Description
As reported in #374, transaction size hasn't been checked in consensus code, although we have a global chain parameter maximum_transaction_size.

bitshares-core/libraries/chain/include/graphene/chain/protocol/chain_parameters.hpp

Line 42 in 58c0c49

uint32_t maximum_transaction_size = GRAPHENE_DEFAULT_MAX_TRANSACTION_SIZE; ///< maximum allowable size in bytes for a transaction

Note: before enabling this check with a hard fork, we should set the parameter to a fair value to avoid breaking things.

Impacts
Describe which portion(s) of BitShares Core may be impacted by this bug. Please tick at least one box.

• API (the application programming interface)
• Build (the build process or something prior to compiled code)
• CLI (the command line wallet)
• Deployment (the deployment process after building such as Docker, Travis, etc.)
• DEX (the Decentralized EXchange, market engine, etc.)
• P2P (the peer-to-peer network for transaction/block propagation)
• Performance (system or user efficiency, etc.)
• Protocol (the blockchain logic, consensus, validation, etc.)
• Security (the security of system or user data, etc.)
• UX (the User Experience)
• Other (please add below)

CORE TEAM TASK LIST

• Evaluate / Prioritize Bug Report
• Refine User Stories / Requirements
• Define Test Cases
• Design / Develop Solution
• Perform QA/Testing
• Update Documentation

[jmjatlanta]

GRAPHENE_DEFAULT_MAX_TRANSACTION_SIZE is set to 2048, which I believe is way too low. So I agree with Abit. The maximum_transaction_size should be adjusted prior to the hardfork.

[pmconrad]

What is the biggest transaction we had in mainnet so far?

[jmjatlanta]

I will be doing a reindex tonight. I will attempt to capture that information.

[jmjatlanta]

Fixed by #1586 Biggest transaction to date: 1,008,285

[xeroc]

I'll propose to committee to set a max tx size of 1,024,000

[clockworkgr]

I'll propose to committee to set a max tx size of 1,024,000

1,048,576 please...let's not mix SI and IEC prefixes :)

[jmjatlanta]

The best thing about standards is there are so many to choose from. I vote for 1,010,101 as it looks more "techie" :-D

[clockworkgr]

1234567 ? easy to remember