Skip to content

Commit ebbb8db

Browse files
committed
Add note
1 parent 6e56261 commit ebbb8db

File tree

3 files changed

+12
-0
lines changed

3 files changed

+12
-0
lines changed

.github/workflows/build-and-test.ubuntu-debug.yml

+4
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@ jobs:
99
strategy:
1010
matrix:
1111
os: [ ubuntu-20.04 ]
12+
# Note:
13+
# Ideally we should only build once per OS, and run tests once per OS per ES version.
14+
# Due to some limitations of Github Actions, it takes too much effort to implement and maintain.
15+
# For simplicity, we use an ES matrix here, although it results in multiple builds per OS.
1216
es: [ "elasticsearch:7.17.8", "elasticsearch:8.5.3" ]
1317
runs-on: ${{ matrix.os }}
1418
services:

.github/workflows/build-and-test.ubuntu-release.yml

+4
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@ jobs:
99
strategy:
1010
matrix:
1111
os: [ ubuntu-20.04 ]
12+
# Note:
13+
# Ideally we should only build once per OS, and run tests once per OS per ES version.
14+
# Due to some limitations of Github Actions, it takes too much effort to implement and maintain.
15+
# For simplicity, we use an ES matrix here, although it results in multiple builds per OS.
1216
es: [ "elasticsearch:7.17.8", "elasticsearch:8.5.3" ]
1317
runs-on: ${{ matrix.os }}
1418
services:

.github/workflows/sonar-scan.yml

+4
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@ jobs:
99
strategy:
1010
matrix:
1111
os: [ ubuntu-20.04 ]
12+
# Note:
13+
# Ideally we should only build once per OS, and run tests once per OS per ES version.
14+
# Due to some limitations of Github Actions, it takes too much effort to implement and maintain.
15+
# For simplicity, we use an ES matrix here, although it results in multiple builds per OS.
1216
es: [ "elasticsearch:8.5.3" ]
1317
runs-on: ${{ matrix.os }}
1418
services:

0 commit comments

Comments
 (0)