Reduce log level of exceptions in order_update_op

Author: abitmore

libraries/chain/exceptions.cpp

@@ -84,6 +84,10 @@ namespace graphene { namespace chain {
    GRAPHENE_IMPLEMENT_OP_EVALUATE_EXCEPTION( insufficient_balance, limit_order_create, 6,
          "Insufficient balance" )
 
+   GRAPHENE_IMPLEMENT_OP_BASE_EXCEPTIONS( limit_order_update );
+   GRAPHENE_IMPLEMENT_OP_EVALUATE_EXCEPTION( nonexist_order, limit_order_update, 1, "Order does not exist" )
+   GRAPHENE_IMPLEMENT_OP_EVALUATE_EXCEPTION( owner_mismatch, limit_order_update, 2, "Order owned by someone else" )
+
    GRAPHENE_IMPLEMENT_OP_BASE_EXCEPTIONS( limit_order_cancel );
    GRAPHENE_IMPLEMENT_OP_EVALUATE_EXCEPTION( nonexist_order, limit_order_cancel, 1, "Order does not exist" )
    GRAPHENE_IMPLEMENT_OP_EVALUATE_EXCEPTION( owner_mismatch, limit_order_cancel, 2, "Order owned by someone else" )

libraries/chain/include/graphene/chain/exceptions.hpp

@@ -138,6 +138,10 @@ namespace graphene { namespace chain {
    GRAPHENE_DECLARE_OP_EVALUATE_EXCEPTION( receiving_asset_unauthorized, limit_order_create, 5 )
    GRAPHENE_DECLARE_OP_EVALUATE_EXCEPTION( insufficient_balance, limit_order_create, 6 )
 
+   GRAPHENE_DECLARE_OP_BASE_EXCEPTIONS( limit_order_update );
+   GRAPHENE_DECLARE_OP_EVALUATE_EXCEPTION( nonexist_order, limit_order_update, 1 )
+   GRAPHENE_DECLARE_OP_EVALUATE_EXCEPTION( owner_mismatch, limit_order_update, 2 )
+
    GRAPHENE_DECLARE_OP_BASE_EXCEPTIONS( limit_order_cancel );
    GRAPHENE_DECLARE_OP_EVALUATE_EXCEPTION( nonexist_order, limit_order_cancel, 1 )
    GRAPHENE_DECLARE_OP_EVALUATE_EXCEPTION( owner_mismatch, limit_order_cancel, 2 )

libraries/chain/market_evaluator.cpp

@@ -156,10 +156,19 @@ void_result limit_order_update_evaluator::do_evaluate(const limit_order_update_o
 {
    const database& d = db();
    FC_ASSERT( HARDFORK_CORE_1604_PASSED( d.head_block_time() ) , "Operation has not activated yet");
-   _order = &o.order(d);
+
+   _order = d.find( o.order );
+
+   GRAPHENE_ASSERT( _order != nullptr,
+                    limit_order_update_nonexist_order,
+                    "Limit order ${oid} does not exist, cannot update",
+                    ("oid", o.order) );
 
    // Check this is my order
-   FC_ASSERT(o.seller == _order->seller, "Cannot update someone else's order");
+   GRAPHENE_ASSERT( o.seller == _order->seller,
+                    limit_order_update_owner_mismatch,
+                    "Limit order ${oid} is owned by someone else, cannot update",
+                    ("oid", o.order) );
 
    // Check new price is compatible and appropriate
    if (o.new_price) {

libraries/net/node.cpp

@@ -3630,6 +3630,8 @@ namespace graphene { namespace net { namespace detail {
           case graphene::chain::limit_order_create_selling_asset_unauthorized::code_enum::code_value :
           case graphene::chain::limit_order_create_receiving_asset_unauthorized::code_enum::code_value :
           case graphene::chain::limit_order_create_insufficient_balance::code_enum::code_value :
+          case graphene::chain::limit_order_update_nonexist_order::code_enum::code_value :
+          case graphene::chain::limit_order_update_owner_mismatch::code_enum::code_value :
           case graphene::chain::limit_order_cancel_nonexist_order::code_enum::code_value :
           case graphene::chain::limit_order_cancel_owner_mismatch::code_enum::code_value :
           case graphene::chain::liquidity_pool_exchange_unfillable_price::code_enum::code_value :