Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove cypher read clause restriction. #601

Merged
merged 1 commit into from
Dec 15, 2022
Merged

fix: remove cypher read clause restriction. #601

merged 1 commit into from
Dec 15, 2022

Conversation

emotionbug
Copy link
Contributor

@emotionbug emotionbug commented Dec 9, 2022

#589

It seems to be a transaction issue related to the removed logic now, but it needs to be checked.

if (node->js.jointype == JOIN_CYPHER_MERGE ||
node->js.jointype == JOIN_CYPHER_DELETE)
{
svCid = innerPlan->state->es_snapshot->curcid;
innerPlan->state->es_snapshot->curcid = node->nl_graphwrite_cid;
}
innerTupleSlot = ExecProcNode(innerPlan);
econtext->ecxt_innertuple = innerTupleSlot;
if (svCid != InvalidCommandId)
innerPlan->state->es_snapshot->curcid = svCid;
if (TupIsNull(innerTupleSlot))
{
ENL1_printf("no inner tuple, need new outer tuple");
node->nl_NeedNewOuter = true;
if (!node->nl_MatchedOuter &&
(node->js.jointype == JOIN_LEFT ||
node->js.jointype == JOIN_CYPHER_MERGE ||
node->js.jointype == JOIN_CYPHER_DELETE ||
node->js.jointype == JOIN_ANTI))
{
/*
* We are doing an outer join and there were no join matches
* for this outer tuple. Generate a fake join tuple with
* nulls for the inner tuple, and return it if it passes the
* non-join quals.
*/

@emotionbug emotionbug merged commit 21d37de into main Dec 15, 2022
@emotionbug emotionbug deleted the issue_589 branch December 15, 2022 05:24
emotionbug added a commit that referenced this pull request Dec 19, 2022
emotionbug added a commit that referenced this pull request Dec 19, 2022
(cherry picked from commit 21d37de)
(cherry picked from commit f1bdb55)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant