Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn if stdin is a terminal #303

Merged
merged 1 commit into from
Oct 30, 2019
Merged

Warn if stdin is a terminal #303

merged 1 commit into from
Oct 30, 2019

Conversation

mkmik
Copy link
Collaborator

@mkmik mkmik commented Oct 30, 2019 •
edited
Loading

Apparently a few people have been burned by the "read from stdin" aspect of kubeseal UX.
(There is a thread on slack where a few people have reported being confused)

@mkmik mkmik requested a review from atomatt October 30, 2019 11:46
@mkmik mkmik added this to the v0.9.3 milestone Oct 30, 2019
@mkmik mkmik requested a review from jjo October 30, 2019 11:46
jjo
jjo approved these changes Oct 30, 2019
View reviewed changes
Copy link

@jjo jjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the good UX care

@mkmik
Copy link
Collaborator Author

mkmik commented Oct 30, 2019

bors r+

bors bot added a commit that referenced this pull request Oct 30, 2019
@bors
Merge #303
f64ee25 
303: Warn if stdin is a terminal r=mkmik a=mkmik

Apparently a few people have been burned by the "read from stdin" aspect of kubeseal UX.
(There is a thread on slack where a few people have reported being confused)

Co-authored-by: Marko Mikulicic <mkm@bitnami.com>
@bors
Copy link
Contributor

bors bot commented Oct 30, 2019

Timed out

@mkmik
Copy link
Collaborator Author

mkmik commented Oct 30, 2019

bors r+

bors bot added a commit that referenced this pull request Oct 30, 2019
@bors
Merge #303
313b252 
303: Warn if stdin is a terminal r=mkmik a=mkmik

Apparently a few people have been burned by the "read from stdin" aspect of kubeseal UX.
(There is a thread on slack where a few people have reported being confused)

Co-authored-by: Marko Mikulicic <mkm@bitnami.com>
@bors
Copy link
Contributor

bors bot commented Oct 30, 2019

Build succeeded

@bors bors bot merged commit bafb65f into master Oct 30, 2019
@bors bors bot deleted the tty branch October 30, 2019 13:54
@chainlink
Copy link

oh man, thank you, this was a major facepalm moment when I figured out I was incorrect interpreting the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjo jjo jjo approved these changes

@atomatt atomatt Awaiting requested review from atomatt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.9.3
Development

Successfully merging this pull request may close these issues.
3 participants
@mkmik @chainlink @jjo