feat: config ui #103
Merged
feat: config ui #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package.json # pi-image/satellite.service # src/client.ts # yarn.lock
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #82
Replaces #84
Replaces #95
Fixes #45
The rest api will now serve a web interface for configuration.
The tray has been simplified, as the same interface is hosted in an electron window too
This works with the api disabled
The styling of this page is a bit crude, I expect it will be refined over time.
The config file has now moved with this, in the existing pi images it appears that satellite is unable to write to the config file, so it is a bit broken..
Instead the json file has been put into the user folder. The existing file in the boot partition is preserved and is read at launch of satellite to update the config json before the main app launch. After it is read, it is reset back to a default state. This will allow users to keep the same manual edit flow, without forcing them to edit a json file correctly, and avoiding the permission issues (we can run that pre-step as root)
TODO:
review config file structure. Could it be tidied without breaking existing electron installations?readme to live next to the pi configscript to generate the config json to bake into the pi image