Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create PendingIntents using TaskStackBuilder #1291

Open
rfc2822 opened this issue Feb 2, 2025 · 1 comment · May be fixed by #1293
Open

Create PendingIntents using TaskStackBuilder #1291

rfc2822 opened this issue Feb 2, 2025 · 1 comment · May be fixed by #1293
Assignees
@ArnyminerZ
Labels
refactoring Internal improvement of existing functions

Comments

@rfc2822
Copy link
Member

rfc2822 commented Feb 2, 2025 •
edited
Loading

We're currently creating PendingIntents using PendingIntent.getActivity(…).

However the current state-of-the-art seems to be TaskStackBuilder, also for Compose deep links.

This automatically also solves "Use of implicit PendingIntents" CodeQL alerts like this one.

(Please have second look @ArnyminerZ whether it really should be done like that)
@rfc2822 rfc2822 added the refactoring Internal improvement of existing functions label Feb 2, 2025
@ArnyminerZ
Copy link
Member

Mmmmh looks like it. We should use this method. A bit too long for me, and the syntax is a bit ugly, but I guess it is what it is. I'll open a PR now.

@ArnyminerZ ArnyminerZ linked a pull request Feb 3, 2025 that will close this issue
Use TaskStackBuilder instead of PendingIntent.getActivity #1293
Open
4 tasks
@sunkup sunkup moved this from Todo to In Review in DAVx⁵ Releases Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArnyminerZ ArnyminerZ

Labels
refactoring Internal improvement of existing functions
Projects
DAVx⁵ Releases
Status: In Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use TaskStackBuilder instead of PendingIntent.getActivity bitfireAT/davx5-ose
2 participants
@rfc2822 @ArnyminerZ