Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export witnessStackToScriptWitness #1648

Closed
monokh opened this issue Nov 2, 2020 · 2 comments
Closed

Export witnessStackToScriptWitness #1648

monokh opened this issue Nov 2, 2020 · 2 comments

Comments

@monokh
Copy link

monokh commented Nov 2, 2020 •
edited
Loading

For PSBT signing, the witnessStackToScriptWitness and witnessStackToScriptWitness functions are useful for apps trying to spend from custom scripts.

As it is not exported, it is being duplicated for the users of bitcoinjs-lib. Is it a good idea to export these?
@sisou
Copy link

sisou commented Jul 30, 2021

We are signing HTLC redeem transaction at Nimiq, and we are duplicating these methods in our code. If they can be exported, that would be great!

Closed
@jasonandjay
Copy link
Member

More discussion welcome in #1862, close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sisou @jasonandjay @monokh