Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asymmetry between network used by descriptor template build method and tests check method #992

Open
vladimirfomene opened this issue May 25, 2023 · 0 comments
Open

Asymmetry between network used by descriptor template build method and tests check method #992

vladimirfomene opened this issue May 25, 2023 · 0 comments
Labels
module-descriptor new feature New feature or request

Comments

@vladimirfomene
Copy link
Contributor

Describe the enhancement
In our descriptor template code, we use different network in the check method of the test and the template's build method. This makes the code confusing. It will be great to use the same network across those methods.

Additional context
See this comment #840 (comment) for more explanation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module-descriptor new feature New feature or request
Projects
BDK
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@notmandatory @vladimirfomene