Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust-bitcoin 0.30.0 upgrade may be annoying #916

Closed
tcharding opened this issue Mar 22, 2023 · 5 comments
Closed

rust-bitcoin 0.30.0 upgrade may be annoying #916

tcharding opened this issue Mar 22, 2023 · 5 comments
Milestone
1.0.0-alpha.2

Comments

@tcharding
Copy link
Contributor

Hi,

We just released v0.30.0 of rust-bitcoin, assuming you guys are going to upgrade, can I ask a favour please. If the upgrade is painful can you please give me feedback. There is a fair bit of churn going on with crate smashing and I'd like to make it as painless as possible for downstream. I don't personally work on any code that uses rust-bitcoin so I have a tendency to get tunnel vision.

If its super painful, just prod me and I can lend a hand.

Thanks
@notmandatory
Copy link
Member

Thanks, we'll also need rust-bitcoin/rust-miniscript#527 to be released, but we can still start getting a bdk PR ready.

@tcharding
Copy link
Contributor Author

tcharding commented Mar 23, 2023 •
edited
Loading

Oh of course, I probably should help out there first huh :)

@benthecarman benthecarman mentioned this issue Mar 23, 2023
Closed
@LLFourn LLFourn mentioned this issue Jul 13, 2023
Closed
24 tasks
@notmandatory notmandatory mentioned this issue Jul 13, 2023
Merged
3 tasks
@notmandatory
Copy link
Member

Reopening this issue since @danielabrozzoni is working on it in #1023.

@notmandatory notmandatory reopened this Jul 13, 2023
@notmandatory notmandatory moved this to In Progress in BDK Wallet Jul 13, 2023
@notmandatory notmandatory added this to the 1.0.0-alpha.2 milestone Jul 13, 2023
@notmandatory notmandatory moved this from In Progress to Needs Review in BDK Wallet Jul 26, 2023
@nondiremanuel
Copy link

@notmandatory shall we close this issue? I saw that #1023 was merged

@notmandatory
Copy link
Member

Yes! fixed by #1023.

@github-project-automation github-project-automation bot moved this from Needs Review to Done in BDK Wallet Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
BDK Wallet
Archived in project
Milestone
1.0.0-alpha.2
Development

No branches or pull requests
3 participants
@notmandatory @tcharding @nondiremanuel