Skip to content

Commit 908b0f9

Browse files
committed
Merge #1183: Bump MSRV to 1.63.0
169385b ci: change MSRV to 1.63.0 (Steve Myers) Pull request description: ### Description fixes #331 ### Notes to the reviewers We won't merge this PR until LDK merges lightningdevkit/rust-lightning#2681. There are alot of clippy checks to fix at 1.63.0 so I left the clippy MSRV at 1.57.0 for now. ### Changelog notice Changed - MSRV is now 1.63.0 for bdk, chain, and bitcoind_rpc crates ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing ACKs for top commit: evanlinjin: ACK 169385b Tree-SHA512: ad69038173b4f050b57f637fc06a4153cf76929992cfea77e3f25d1e66be102bd2f83a46401a7e3245e9cc54602210c95b75a578f18c5c8b55d1e7229e92197f
2 parents f741122 + 169385b commit 908b0f9

File tree

6 files changed

+16
-64
lines changed

6 files changed

+16
-64
lines changed

.github/workflows/cont_integration.yml

+4-20
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
rust:
1313
- version: stable
1414
clippy: true
15-
- version: 1.57.0 # MSRV
15+
- version: 1.63.0 # MSRV
1616
features:
1717
- --no-default-features
1818
- --all-features
@@ -28,28 +28,12 @@ jobs:
2828
- name: Rust Cache
2929
uses: Swatinem/rust-cache@v2.2.1
3030
- name: Pin dependencies for MSRV
31-
if: matrix.rust.version == '1.57.0'
31+
if: matrix.rust.version == '1.63.0'
3232
run: |
33-
cargo update -p log --precise "0.4.18"
34-
cargo update -p tempfile --precise "3.6.0"
35-
cargo update -p reqwest --precise "0.11.18"
36-
cargo update -p hyper-rustls --precise 0.24.0
37-
cargo update -p rustls:0.21.9 --precise "0.21.1"
38-
cargo update -p rustls:0.20.9 --precise "0.20.8"
39-
cargo update -p tokio --precise "1.29.1"
40-
cargo update -p tokio-util --precise "0.7.8"
41-
cargo update -p flate2 --precise "1.0.26"
42-
cargo update -p h2 --precise "0.3.20"
43-
cargo update -p rustls-webpki:0.100.3 --precise "0.100.1"
44-
cargo update -p rustls-webpki:0.101.7 --precise "0.101.1"
4533
cargo update -p zip --precise "0.6.2"
46-
cargo update -p time --precise "0.3.13"
47-
cargo update -p byteorder --precise "1.4.3"
48-
cargo update -p webpki --precise "0.22.2"
49-
cargo update -p os_str_bytes --precise 6.5.1
50-
cargo update -p sct --precise 0.7.0
51-
cargo update -p cc --precise "1.0.81"
34+
cargo update -p time --precise "0.3.20"
5235
cargo update -p jobserver --precise "0.1.26"
36+
cargo update -p reqwest --precise "0.11.19"
5337
- name: Build
5438
run: cargo build ${{ matrix.features }}
5539
- name: Test

README.md

+8-40
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<a href="https://github.com/bitcoindevkit/bdk/actions?query=workflow%3ACI"><img alt="CI Status" src="https://github.com/bitcoindevkit/bdk/workflows/CI/badge.svg"></a>
1616
<a href="https://coveralls.io/github/bitcoindevkit/bdk?branch=master"><img src="https://coveralls.io/repos/github/bitcoindevkit/bdk/badge.svg?branch=master"/></a>
1717
<a href="https://docs.rs/bdk"><img alt="API Docs" src="https://img.shields.io/badge/docs.rs-bdk-green"/></a>
18-
<a href="https://blog.rust-lang.org/2021/12/02/Rust-1.57.0.html"><img alt="Rustc Version 1.57.0+" src="https://img.shields.io/badge/rustc-1.57.0%2B-lightgrey.svg"/></a>
18+
<a href="https://blog.rust-lang.org/2022/08/11/Rust-1.63.0.html"><img alt="Rustc Version 1.63.0+" src="https://img.shields.io/badge/rustc-1.63.0%2B-lightgrey.svg"/></a>
1919
<a href="https://discord.gg/d7NkDKm"><img alt="Chat on Discord" src="https://img.shields.io/discord/753336465005608961?logo=discord"></a>
2020
</p>
2121

@@ -60,51 +60,19 @@ Fully working examples of how to use these components are in `/example-crates`:
6060
[`bdk_chain`]: https://docs.rs/bdk-chain/
6161

6262
## Minimum Supported Rust Version (MSRV)
63-
This library should compile with any combination of features with Rust 1.57.0.
63+
This library should compile with any combination of features with Rust 1.63.0.
6464

6565
To build with the MSRV you will need to pin dependencies as follows:
6666

6767
```shell
68-
# log 0.4.19 has MSRV 1.60.0+
69-
cargo update -p log --precise "0.4.18"
70-
# tempfile 3.7.0 has MSRV 1.63.0+
71-
cargo update -p tempfile --precise "3.6.0"
72-
# reqwest 0.11.19 has MSRV 1.63.0+
73-
cargo update -p reqwest --precise "0.11.18"
74-
# hyper-rustls 0.24.1 has MSRV 1.60.0+
75-
cargo update -p hyper-rustls --precise 0.24.0
76-
# rustls 0.21.7 has MSRV 1.60.0+
77-
cargo update -p rustls:0.21.9 --precise "0.21.1"
78-
# rustls 0.20.9 has MSRV 1.60.0+
79-
cargo update -p rustls:0.20.9 --precise "0.20.8"
80-
# tokio 1.33 has MSRV 1.63.0+
81-
cargo update -p tokio --precise "1.29.1"
82-
# tokio-util 0.7.9 doesn't build with MSRV 1.57.0
83-
cargo update -p tokio-util --precise "0.7.8"
84-
# flate2 1.0.27 has MSRV 1.63.0+
85-
cargo update -p flate2 --precise "1.0.26"
86-
# h2 0.3.21 has MSRV 1.63.0+
87-
cargo update -p h2 --precise "0.3.20"
88-
# rustls-webpki 0.100.3 has MSRV 1.60.0+
89-
cargo update -p rustls-webpki:0.100.3 --precise "0.100.1"
90-
# rustls-webpki 0.101.2 has MSRV 1.60.0+
91-
cargo update -p rustls-webpki:0.101.7 --precise "0.101.1"
92-
# zip 0.6.6 has MSRV 1.59.0+
68+
# zip 0.6.3 has MSRV 1.64.0+
9369
cargo update -p zip --precise "0.6.2"
94-
# time 0.3.14 has MSRV 1.59.0+
95-
cargo update -p time --precise "0.3.13"
96-
# byteorder 1.5.0 has MSRV 1.60.0+
97-
cargo update -p byteorder --precise "1.4.3"
98-
# webpki 0.22.4 requires `ring:0.17.2` which has MSRV 1.61.0+
99-
cargo update -p webpki --precise "0.22.2"
100-
# os_str_bytes 6.6.0 has MSRV 1.61.0+
101-
cargo update -p os_str_bytes --precise 6.5.1
102-
# sct 0.7.1 has MSRV 1.61.0+
103-
cargo update -p sct --precise 0.7.0
104-
# cc 1.0.82 has MSRV 1.61.0+
105-
cargo update -p cc --precise "1.0.81"
106-
# jobserver 0.1.27 has MSRV 1.66.0+
70+
# time 0.3.21 has MSRV 1.65.0+
71+
cargo update -p time --precise "0.3.20"
72+
# jobserver 0.1.27 has MSRV 1.66.0
10773
cargo update -p jobserver --precise "0.1.26"
74+
# reqwest 0.11.20 has MSRV > 1.63.0+
75+
cargo update -p reqwest --precise "0.11.19"
10876
```
10977

11078
## License

crates/bdk/Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ readme = "README.md"
1010
license = "MIT OR Apache-2.0"
1111
authors = ["Bitcoin Dev Kit Developers"]
1212
edition = "2021"
13-
rust-version = "1.57"
13+
rust-version = "1.63"
1414

1515
[dependencies]
1616
rand = "^0.8"

crates/bdk/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<a href="https://github.com/bitcoindevkit/bdk/actions?query=workflow%3ACI"><img alt="CI Status" src="https://github.com/bitcoindevkit/bdk/workflows/CI/badge.svg"></a>
1414
<a href="https://coveralls.io/github/bitcoindevkit/bdk?branch=master"><img src="https://coveralls.io/repos/github/bitcoindevkit/bdk/badge.svg?branch=master"/></a>
1515
<a href="https://docs.rs/bdk"><img alt="API Docs" src="https://img.shields.io/badge/docs.rs-bdk-green"/></a>
16-
<a href="https://blog.rust-lang.org/2021/12/02/Rust-1.57.0.html"><img alt="Rustc Version 1.57.0+" src="https://img.shields.io/badge/rustc-1.57.0%2B-lightgrey.svg"/></a>
16+
<a href="https://blog.rust-lang.org/2022/08/11/Rust-1.63.0.html"><img alt="Rustc Version 1.63.0+" src="https://img.shields.io/badge/rustc-1.63.0%2B-lightgrey.svg"/></a>
1717
<a href="https://discord.gg/d7NkDKm"><img alt="Chat on Discord" src="https://img.shields.io/discord/753336465005608961?logo=discord"></a>
1818
</p>
1919

crates/bitcoind_rpc/Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
name = "bdk_bitcoind_rpc"
33
version = "0.1.0"
44
edition = "2021"
5-
rust-version = "1.57"
5+
rust-version = "1.63"
66
homepage = "https://bitcoindevkit.org"
77
repository = "https://github.com/bitcoindevkit/bdk"
88
documentation = "https://docs.rs/bdk_bitcoind_rpc"

crates/chain/Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
name = "bdk_chain"
33
version = "0.6.0"
44
edition = "2021"
5-
rust-version = "1.57"
5+
rust-version = "1.63"
66
homepage = "https://bitcoindevkit.org"
77
repository = "https://github.com/bitcoindevkit/bdk"
88
documentation = "https://docs.rs/bdk_chain"

0 commit comments

Comments
 (0)