Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: Set a default user-callback script if none exists (containing how-to instructions) #1331

Open
aryoda opened this issue Oct 10, 2022 · 7 comments
Assignees
Labels
Bug Documentation Feature requests a new feature Qt Qt bugs, code or features Reproduced

Comments

@aryoda
Copy link
Contributor

aryoda commented Oct 10, 2022

If you are a first time contributor...

Welcome to the project, if you pick up this Issue because of the "GOOD FIRST USE" label. You will be mentored through the process if you want. This issue is quit old and may lack some details important for new contributors. Just raise your hand and we will provide more details. Please do not hesitate to ask questions. Your solution don't need to be perfect.

The Problem

This is a feature request taken from: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=985257

Actual behaviour:

If no user-callback script exists and a user clicks on

settings > general > Edit user-callback

an empty user-callback editor windows is shown.

Impact

A normal user cannot understand what to do here and where to find documentation to learn more.

Expected behavior:

If no user-callback script file exists a default script (that does nothing!) should be shown.

The script should include the relevant documentation and links for an easy start.

BTW: There are already some user-callback scripts in the BiT repo that could be used: https://github.com/bit-team/user-callback

Possible extension (gold standard ;-)

A button could be added to the "user-callback" editor window which offers a choice of different default user-callback scripts
for different purposes.

Make sure that the existing user-callback is not overwritten without explicitly asking the user and making a backup!

@emtiu emtiu added Reproduced Feature requests a new feature Bug labels Oct 16, 2022
@buhtz buhtz added this to the 1.3.5 / 1.4.0 milestone Mar 19, 2023
@buhtz buhtz added GOOD FIRST ISSUE Used by 24pullrequests.com to suggest issues HELP-WANTED Used by 24pullrequests.com to suggest issues labels Dec 7, 2023
@buhtz
Copy link
Member

buhtz commented Feb 27, 2024

Do you have an idea about how to integrate "documentation" into this workflow?

Maybe create an extra markdown file in the repo and offer a link in the edit-user-callback-dialog? Or is this too lazy? ;)
Or we really create a section in the user manual (see #1659) we can then link to?

@aryoda
Copy link
Contributor Author

aryoda commented Feb 27, 2024

Do you have an idea about how to integrate "documentation" into this workflow?

Perhaps add a "help" button

  • linking to a specific page in our user-callback repo
  • or showing the user-callback section of the installed man backintime.

Also adding enough comments to our default user-callback scripts could help (and mention there man backintime).

@buhtz
Copy link
Member

buhtz commented Feb 28, 2024

Sounds good to me.

@emtiu
Copy link
Member

emtiu commented Feb 29, 2024

My instinct would be a much simpler solution: Display an empty dummy-callback script with commented-out example code, and a few URLs to further help :)

Or maybe paths to local files with documentation, if we want to keep it offline.

@buhtz
Copy link
Member

buhtz commented Sep 23, 2024

@buhtz buhtz self-assigned this Sep 23, 2024
@buhtz buhtz removed GOOD FIRST ISSUE Used by 24pullrequests.com to suggest issues HELP-WANTED Used by 24pullrequests.com to suggest issues labels Sep 23, 2024
@buhtz buhtz added the Qt Qt bugs, code or features label Sep 23, 2024
@buhtz
Copy link
Member

buhtz commented Oct 17, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Documentation Feature requests a new feature Qt Qt bugs, code or features Reproduced
Projects
None yet
Development

No branches or pull requests

3 participants