crashes, when trying to diff

[freder]

version 1.2.1

every time I do either of these, the program crashes:

• view → snapshots → diff
• view → snapshots → diff options → ok

5/3/20 8:57 PM	python	Traceback (most recent call last):
File "/usr/share/backintime/qt/snapshotsdialog.py", line 339, in btnDiffClicked
	path1 = self.parent.tmpCopy(path1, sid1)
File "/usr/share/backintime/qt/app.py", line 1266, in tmpCopy
	shutil.copytree(full_path, tmp_file)
File "/usr/lib/python3.8/shutil.py", line 554, in copytree
	return _copytree(entries=entries, src=src, dst=dst, symlinks=symlinks,
File "/usr/lib/python3.8/shutil.py", line 455, in _copytree
	os.makedirs(dst, exist_ok=dirs_exist_ok)
File "/usr/lib/python3.8/os.py", line 223, in makedirs
	mkdir(name, mode)
FileExistsError: [Errno 17] File exists: '/tmp/tmpkt7c6arq_20200503-191846-429/'

[frithrah]

For the record, I have the same consistent crash but a different error...

Traceback (most recent call last):
  File "/usr/share/backintime/qt/snapshotsdialog.py", line 76, in accept
    diffCmd = str(self.editCmd.text().toUtf8())
AttributeError: 'str' object has no attribute 'toUtf8'

[buhtz]

@freder There is a new forming maintaining team and we do review all issues. Is this problem still relevant for you or did you find a solution?

Tag: Feedback, Bug, Qt

[buhtz]

For the record, I have the same consistent crash but a different error...

Traceback (most recent call last):
  File "/usr/share/backintime/qt/snapshotsdialog.py", line 76, in accept
    diffCmd = str(self.editCmd.text().toUtf8())
AttributeError: 'str' object has no attribute 'toUtf8'

This is different from the opening report. Your problem (error about missing `toUtf8()) is fixed (via #1246) in the current upstream version. That version is not released yet.

[emtiu]

Possible duplicate of #1197?

[buhtz]

Dear @freder ,
can you report back please if you are still able to reproduce your problem with the latest version (1.3.3) of BIT?

[buhtz]

I've seen this, too in 1.3.4-dev. But again I can't reproduce it for sure.

But I do see a trail and need to further investigate the code.

backintime/qt/snapshotsdialog.py

Lines 342 to 347 in 72ced78

	# prevent backup data from being accidentally overwritten
	# by create a temporary local copy and only open that one
	if not isinstance(sid1, snapshots.RootSnapshot):
	path1 = self.parent.tmpCopy(path1, sid1)
	if not isinstance(sid2, snapshots.RootSnapshot):
	path2 = self.parent.tmpCopy(path2, sid2)

There are two situations / variants of calls to tmpCopy(). But they are not exclusive to each other. It might happen in rare cases that tmpCopy() is called twice. But there is also high evidence that I'm wrong here. I travled Back In Time to version 1.2.1 (the Issue opener used) and had a look at line 339 which was reported in his traceback. This line number refers to the first call of tmpCopy() not the second.

[buhtz]

Frederic we are currently working (#1682) on the snapshots dialog and its compare feature. Can you somehow reproduce the problem with a newer version of BIT and can you provide us the steps to reproduce?

[buhtz]

Closing this ticket based on the comment above. Feel free to reopen
if the problem still exists. Thank you for your efforts. If you have
any further questions, ideas or encounter any other issues, please
don't hesitate to let us know.

Best regards,