Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 50 #1352

Closed
alvasw opened this issue Aug 18, 2023 · 5 comments
Closed

For Cycle 50 #1352

alvasw opened this issue Aug 18, 2023 · 5 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@alvasw
Copy link

alvasw commented Aug 18, 2023

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 10365.85
  • USD requested: 8500
  • BSQ rate: 0.82 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 49 #1334

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
bisq: PR Review bisq-network/bisq#6758 dev bisq-network/bisq#6758
bisq: PR Review bisq-network/bisq#6776 dev bisq-network/bisq#6776
bisq: Remove com.google.osdetector Gradle Plugin dev bisq-network/bisq#6770
bisq: Improve build-time: Lazily apply gRPC plugin dev bisq-network/bisq#6771

For details see:
https://docs.gradle.org/current/userguide/task_configuration_avoidance.html

bisq: Fix broken codacy coverage reporter dev bisq-network/bisq#6772

All PR CI runs fail due to the misconfigured codacy coverage reporter.

bisq: Move codacy-coverage-reporter.yml to workflows dev bisq-network/bisq#6773
bisq: Fix broken stale bot dev bisq-network/bisq#6774
bisq: Gradle: Centralize JavaFX Setup dev bisq-network/bisq#6789
bisq: seednode: Move build configuration to its own build.gradle dev bisq-network/bisq#6790
bisq: statsnode: Move build configuration to its own build.gradle dev bisq-network/bisq#6791
bisq: apitest: Move build configuration to its own build.gradle dev bisq-network/bisq#6792
bisq: Seednode: Disable ShadowJar dev bisq-network/bisq#6793
bisq: Gradle: Centralize Application Setup dev bisq-network/bisq#6794
bisq: Gradle: Apply shadow plugin only to desktop module dev bisq-network/bisq#6795
bisq: Move JVM args to build.gradle files dev bisq-network/bisq#6796
bisq: Only generate coverage reports for the master branch dev bisq-network/bisq#6799
bisq: Implement Transactions for Trade Protocol v5 dev bisq-network/bisq#6801
bisq2: Fix Protobuf Build Setup dev bisq-network/bisq2#1023
bisq2: Enable Gradle Build Cache dev bisq-network/bisq2#1024

See: https://docs.gradle.org/current/userguide/build_cache.html

Based on #1023

bisq2: NativeTorProcess: Bind Tor to ownerPid dev bisq-network/bisq2#1045
bisq2: Tor: Bind Process to Connection dev bisq-network/bisq2#1046

If the the owner pid is set with __OwningControllerProcess, Tor polls to see whether the parent is still running. After establishing the controller connection, we can bind the process to the control socket using the TAKEOWNERSHIP command.

bisq2: Tor: Store torrc configs in map dev bisq-network/bisq2#1047
bisq2: Tor: Create production torrc generator dev bisq-network/bisq2#1048
bisq2: Don't daemonize Tor process dev bisq-network/bisq2#1049
bisq2: Tor: Delay network initialization dev bisq-network/bisq2#1050
bisq2: Tor: Implement bootstrap event handler and listener dev bisq-network/bisq2#1061
bisq2: Tor: Async HS_DESC Creation And Upload dev bisq-network/bisq2#1062
bisq2: Enable Gradle Build Cache for Included Builds dev bisq-network/bisq2#1067
bisq2: build-logic: Make DownloadTask cacheable dev bisq-network/bisq2#1077
bisq2: NativeTorController: Add isHiddenServiceAvailable dev bisq-network/bisq2#1078
bisq2: build-logic: Create URL in DownloadTask dev bisq-network/bisq2#1079
bisq2: Tor: Verify uploaded HS Descriptor dev bisq-network/bisq2#1080
bisq2: GitHub Actions: Cache downloaded binaries dev bisq-network/bisq2#1081
bisq2: Refactor Tor V2 Module dev bisq-network/bisq2#1082
bisq2: Revert "GitHub Actions: Cache downloaded binaries" dev bisq-network/bisq2#1083

Reverts #1081

bisq2: build-logic: Make SignatureVerificationTask cachable dev bisq-network/bisq2#1084
bisq2: Revert "Revert "GitHub Actions: Cache downloaded binaries"" dev bisq-network/bisq2#1085

Reverts #1083

bisq2: build-logic: Verify Tor binary dev bisq-network/bisq2#1086
bisq2: Revert "GitHub Actions: Cache downloaded binaries" dev bisq-network/bisq2#1087

Reverts #1081

bisq2: build-logic: Annotate DownloadTask as cacheable dev bisq-network/bisq2#1088
bisq2: Settings: Add torrc_overrides to typesafe config dev bisq-network/bisq2#1089
bisq2: Pass ConfigMap to TorrcFileGenerator dev bisq-network/bisq2#1090
bisq2: ClientTorrcGenerator: Support config overrides dev bisq-network/bisq2#1091
bisq2: Create production TorrcFileGenerator dev bisq-network/bisq2#1107
bisq2: Tor: Throw Exceptions on Failure dev bisq-network/bisq2#1108
bisq2: Move typesafe torrc_override to TorTransport dev bisq-network/bisq2#1109
bisq2: Typesafe config rename torrc_overrides to torrcOverrides dev bisq-network/bisq2#1117
bisq2: Add Tor DirectoryAuthorities to typesafe config dev bisq-network/bisq2#1118
bisq2: Add Tor testNetwork option to typesafe config dev bisq-network/bisq2#1119
bisq2: TorrcConfigGeneration: Move from inheritance to composition dev bisq-network/bisq2#1122
bisq2: Move tor modules into root tor module dev bisq-network/bisq2#1123
bisq2: Move TorrcConfigGenerator to tor.common module dev bisq-network/bisq2#1125
bisq2: Implement TestNetworkTorrcGeneratorFactory dev bisq-network/bisq2#1128
bisq2: Remove Getter from TestNetworkTorrcGenerator dev bisq-network/bisq2#1129
bisq2: PR Review bisq-network/bisq2#1035 dev bisq-network/bisq2#1035
bisq2: PR Review bisq-network/bisq2#1059 dev bisq-network/bisq2#1059
bisq2: PR Review bisq-network/bisq2#1060 dev bisq-network/bisq2#1060
bisq2: PR Review bisq-network/bisq2#1092 dev bisq-network/bisq2#1092
bisq2: PR Review bisq-network/bisq2#1106 dev bisq-network/bisq2#1106
dev 8500 Total for items above.
@ghost ghost added the parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid label Aug 18, 2023
@ghost
Copy link

ghost commented Aug 18, 2023

Info

Read BSQ amount from summary: 10365.85
Read USD amount from summary: 8500
Read BSQ rate from summary: 0.82
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}

Errors

ERROR: Total USD does not match the sum of line items:

  • Summary total: 8500.00 USD
  • Calculated total: 0.00 USD

@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team and removed parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid labels Aug 18, 2023
@MwithM MwithM added this to the Cycle 50 milestone Aug 18, 2023
@alvasw
Copy link
Author

alvasw commented Aug 22, 2023

2f45d19f64552e96ea3d3837b5111ca890f6f138177dcc3d2198c7f5ef0f6d23

@ripcurlx
Copy link
Contributor

As dev team lead I approve this compensation request.

@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Sep 1, 2023
@ghost
Copy link

ghost commented Sep 1, 2023

Issuance by Team:

team amount BSQ amount USD
dev 10365.85 8500.00

Total Issuance: 10365.85 BSQ (equivalent to: 8500.00 USD)

@MwithM
Copy link
Contributor

MwithM commented Sep 1, 2023

Closed as accepted.

@MwithM MwithM closed this as completed Sep 1, 2023
@alvasw alvasw mentioned this issue Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Archived in project
Development

No branches or pull requests

3 participants