Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 48 #1315

Closed
alvasw opened this issue Jun 15, 2023 · 4 comments
Closed

For Cycle 48 #1315

alvasw opened this issue Jun 15, 2023 · 4 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@alvasw
Copy link

alvasw commented Jun 15, 2023

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 9876.54
  • USD requested: 8000
  • BSQ rate: 0.81 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 47 #1295

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
Remove TOR_BY_APP Map dev bisq-network/bisq2#846

The TOR_BY_APP Map is not needed because we only use one Tor instance.

Start Tor asynchronously dev bisq-network/bisq2#849
TorTransport: Remove unused torDirPath field dev bisq-network/bisq2#850
Tor: Make start and shutdown thread-safe dev bisq-network/bisq2#851

The start and shutdown routine can get triggered multiple times without the synchronization.

Tor: Update state atomically dev bisq-network/bisq2#852

Without this change both state.get() calls can return different states.

Tor: Update state atomatically in shutdown rountine dev bisq-network/bisq2#853

Validate the currentState and set the new state atomically.

Tor: Reformat startAsync method dev bisq-network/bisq2#854
Tor: Atomically update state in doStart() dev bisq-network/bisq2#855
  • Atomically update from NEW to STARTING
  • Extract Tor startup into separate method
Tor: Move RetryPolicy to start-up thread dev bisq-network/bisq2#858
Implement TorService dev bisq-network/bisq2#859
Move SocketChannel implemenation to nio package dev bisq-network/bisq2#860
Tor: Use type-safe Path (instead of path string) dev bisq-network/bisq2#861
Tor: Remove broken tests dev bisq-network/bisq2#862
Implement OnionServiceDataDirManager dev bisq-network/bisq2#863

This change moves the Tor Onion Service Persistence logic to a separate class.

OutboundConnectionManager: Set CompletableFuture result after handshake dev bisq-network/bisq2#864
Move OutboundConnectionsMultiplexerTest to integration tests dev bisq-network/bisq2#865
GitHub Actions: Enable Network Tests dev bisq-network/bisq2#866
Move NetworkEnvelopeSocketChannelTests to integration test dev bisq-network/bisq2#870
Address: Add OnionAddress constructor dev bisq-network/bisq2#871
OnionServDataDirManag: Change constructor from file to path dev bisq-network/bisq2#872
Implement OnionServicePublishService dev bisq-network/bisq2#873
  • TorService: Add createOnionService
  • Transport.ServerSocketResult: Add CreateOnionServiceReponse
    constructor
Tor: Move SocksProxy logic to TorSocksProxyFactory dev bisq-network/bisq2#874
Tor: Move onion service classes to separate package dev bisq-network/bisq2#875
GitHub Actions: Re-enable wallets unit test dev bisq-network/bisq2#876
Move TorInstallFileManager and TorrConfigInstaller out of TorBootstrap dev bisq-network/bisq2#877
Transport: Rename isAddressAvailable to isPeerOnline dev bisq-network/bisq2#881
TorBootstrap: Use TorInstallationFileManager dev bisq-network/bisq2#886
TorBootstrap: Remove unused bridge code dev bisq-network/bisq2#887
TorBootstrap: Use isRunning AtomicBoolean dev bisq-network/bisq2#888
TorBootstrap: Move install logic to TorInstaller dev bisq-network/bisq2#889
Rename TorInstallationFileManager to TorInstallationFiles dev bisq-network/bisq2#890
TorBoostrap: Rename maybeCleanupCookieFile to removeCookieFileIfPresent dev bisq-network/bisq2#891
Move removeCookieFileIfPresent to TorInstalltionFiles class dev bisq-network/bisq2#892
Move Tor process logic to TorProcessBuilder dev bisq-network/bisq2#893
Tor: Document LDD_PRELOAD dev bisq-network/bisq2#911
Move torBinary to TorInstallationFiles dev bisq-network/bisq2#912
Tor: Create new installer java package dev bisq-network/bisq2#913
Move BisqProcess Pid fetching to separate class dev bisq-network/bisq2#914
Implement Tor Directory Authority Cert and Key Generation dev bisq-network/bisq2#918
Implement DirectoryAuthorityTorrcGenerator dev bisq-network/bisq2#926

The DirectoryAuthorityTorrcGenerator creates the torrc config file to run a private tor network. The configuration settings are from the Chutney (https://gitweb.torproject.org/chutney.git/) and Antitree's private-tor-network (https://github.com/antitree/private-tor-network) project.

Other changes:

Implement Tor Relay Key Generator dev bisq-network/bisq2#933
dev 8000 Total for items above.
@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team labels Jun 15, 2023
@MwithM MwithM added this to the Cycle 48 milestone Jun 16, 2023
@alvasw
Copy link
Author

alvasw commented Jun 19, 2023

f91375b9302740ca1bb71f78527f2fc9d2dccc7f0eb82f61b57db3bc81dda7f1

@ripcurlx
Copy link
Contributor

As dev team lead I approve this compensation request for dev.

@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Jun 29, 2023
@ghost
Copy link

ghost commented Jun 29, 2023

Issuance by Team:

team amount BSQ amount USD
dev 9876.54 8000.00

Total Issuance: 9876.54 BSQ (equivalent to: 8000.00 USD)

@MwithM
Copy link
Contributor

MwithM commented Jun 29, 2023

Closed as accepted.

@MwithM MwithM closed this as completed Jun 29, 2023
@alvasw alvasw mentioned this issue Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Archived in project
Development

No branches or pull requests

3 participants