Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capture memory snapshot when the app runs out of memory #3132

Closed
christophsturm opened this issue Aug 23, 2019 · 6 comments
Closed

capture memory snapshot when the app runs out of memory #3132

christophsturm opened this issue Aug 23, 2019 · 6 comments

Comments

@christophsturm
Copy link
Contributor

christophsturm commented Aug 23, 2019

add java -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=bisq-dump to the start script. then people experiencing out of memory errors automatically have a dump file that they can send to us.

optionally check for the dump file at startup and tell people to create an issue. inspired by #3128

@christophsturm
Copy link
Contributor Author

cc @ripcurlx

@battleofwizards
Copy link
Contributor

battleofwizards commented Aug 23, 2019

Memory dumps can potentially contain secrets like private keys, mnemonic seeds, PRNG state, etc.

But maybe that could still be useful if we only allow it for developers (who I assume are testing on regtest and know what they are doing)?

bisq-regtest

@christophsturm
Copy link
Contributor Author

Good point. We should make some memory dumps and see what data they contain.

@christophsturm
Copy link
Contributor Author

or people could just open up the snapshot in jvisualvm and send us a screenshot.

@stale
Copy link

stale bot commented Nov 24, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Nov 24, 2019
@stale
Copy link

stale bot commented Dec 1, 2019

This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant.

@stale stale bot closed this as completed Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants