Skip to content
This repository has been archived by the owner on Dec 6, 2024. It is now read-only.

make "heavy" dependencies optional #5

Closed
cehbrecht opened this issue Jun 15, 2018 · 3 comments
Closed

make "heavy" dependencies optional #5

cehbrecht opened this issue Jun 15, 2018 · 3 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@cehbrecht
Copy link
Member

Currently eggshell has "heavy" dependencies which are required, for example:

  • matplotlib
  • cartopy
  • ocgis

To make eggshell usable also for lightweight birds (wps services) we could make those dependencies optional ... functionality using these libraries is only loaded/available when the libraries are installed (ocgis, matplotlib, ...).

@cehbrecht cehbrecht added enhancement New feature or request help wanted Extra attention is needed labels Jun 15, 2018
@cehbrecht cehbrecht added this to the 0.1.0 milestone Jun 15, 2018
@huard huard self-assigned this Jun 15, 2018
@huard
Copy link
Collaborator

huard commented Jun 15, 2018

I could move those utilities into subpackages. They won't be imported by import eggshell.

Does that mean creating an environment-dev.yml file with those optional dependencies ?

@huard
Copy link
Collaborator

huard commented Jun 15, 2018

Also, I suppose this means that the real birds have the responsibility of having those dependencies, and not delegate non-trivial dependencies to eggshell.

@cehbrecht
Copy link
Member Author

The environment.yml is used for development and we can keep all conda dependencies here, just adding a comment for optional packages. But we should split the requirements.txt which is used by the Python package. Maybe having something like requirements-opt.txt? -dev is already used for the test requirements pytest etc.

Also, I suppose this means that the real birds have the responsibility of having those dependencies ..

yes.

@cehbrecht cehbrecht modified the milestones: 0.1.0, 0.3.0 Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants