Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing sscanf argument validation #129

Open
HorizontalCar opened this issue Apr 9, 2024 · 0 comments
Open

missing sscanf argument validation #129

HorizontalCar opened this issue Apr 9, 2024 · 0 comments

Comments

@HorizontalCar
Copy link

Missing argument validation for sscanf at line ascii_proto_funcs.c:631

bipropellant-hoverboard-firmware/src/ascii_proto_funcs.c

Line 631 in 21bd060

sscanf(&cmd[1], "%lx,%x", (uint32_t *)&addr, &len);

If cmd[1] == null, or similarly, if sscanf does not initilise addr, a null pointer dereference occurs at ascii_proto_funcs.c:636.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@HorizontalCar