chore(linter): rename useConsistentGridAreas to noInvalidGridAreas (

#3809)
biomejs · Sep 6, 2024 · 5f4a8c5 · 5f4a8c5
1 parent 72c6ce6
commit 5f4a8c5
Show file tree

Hide file tree

Showing 11 changed files with 104 additions and 103 deletions.
diff --git a/crates/biome_configuration/src/analyzer/linter/rules.rs b/crates/biome_configuration/src/analyzer/linter/rules.rs
diff --git a/crates/biome_css_analyze/src/lint/nursery.rs b/crates/biome_css_analyze/src/lint/nursery.rs
@@ -8,6 +8,7 @@ pub mod no_duplicate_selectors_keyframe_block;
 pub mod no_empty_block;
 pub mod no_important_in_keyframe;
 pub mod no_invalid_direction_in_linear_gradient;
+pub mod no_invalid_grid_areas;
 pub mod no_invalid_position_at_import_rule;
 pub mod no_irregular_whitespace;
 pub mod no_shorthand_property_overrides;
@@ -19,7 +20,6 @@ pub mod no_unknown_selector_pseudo_element;
 pub mod no_unknown_unit;
 pub mod no_unmatchable_anb_selector;
 pub mod no_value_at_rule;
-pub mod use_consistent_grid_areas;
 pub mod use_generic_font_names;
 
 declare_lint_group! {
@@ -32,6 +32,7 @@ declare_lint_group! {
             self :: no_empty_block :: NoEmptyBlock ,
             self :: no_important_in_keyframe :: NoImportantInKeyframe ,
             self :: no_invalid_direction_in_linear_gradient :: NoInvalidDirectionInLinearGradient ,
+            self :: no_invalid_grid_areas :: NoInvalidGridAreas ,
             self :: no_invalid_position_at_import_rule :: NoInvalidPositionAtImportRule ,
             self :: no_irregular_whitespace :: NoIrregularWhitespace ,
             self :: no_shorthand_property_overrides :: NoShorthandPropertyOverrides ,
@@ -43,7 +44,6 @@ declare_lint_group! {
             self :: no_unknown_unit :: NoUnknownUnit ,
             self :: no_unmatchable_anb_selector :: NoUnmatchableAnbSelector ,
             self :: no_value_at_rule :: NoValueAtRule ,
-            self :: use_consistent_grid_areas :: UseConsistentGridAreas ,
             self :: use_generic_font_names :: UseGenericFontNames ,
         ]
      }

diff --git a/...lint/nursery/use_consistent_grid_areas.rs → ...src/lint/nursery/no_invalid_grid_areas.rs b/...lint/nursery/use_consistent_grid_areas.rs → ...src/lint/nursery/no_invalid_grid_areas.rs
@@ -48,9 +48,9 @@ declare_lint_rule! {
     ///                          "a a a"; }
     /// ```
     ///
-    pub UseConsistentGridAreas {
+    pub NoInvalidGridAreas {
         version: "next",
-        name: "useConsistentGridAreas",
+        name: "noInvalidGridAreas",
         language: "css",
         recommended: false,
         sources: &[RuleSource::Stylelint("named-grid-areas-no-invalid")],
@@ -73,7 +73,7 @@ pub struct UseConsistentGridAreasState {
     reason: GridAreaValidationError,
 }
 
-impl Rule for UseConsistentGridAreas {
+impl Rule for NoInvalidGridAreas {
     type Query = Ast<CssDeclarationOrRuleList>;
     type State = UseConsistentGridAreasState;
     type Signals = Option<Self::State>;

diff --git a/crates/biome_css_analyze/src/options.rs b/crates/biome_css_analyze/src/options.rs
diff --git a/...ursery/useConsistentGridAreas/invalid.css → ...cs/nursery/noInvalidGridAreas/invalid.css b/...ursery/useConsistentGridAreas/invalid.css → ...cs/nursery/noInvalidGridAreas/invalid.css
diff --git a/...y/useConsistentGridAreas/invalid.css.snap → ...rsery/noInvalidGridAreas/invalid.css.snap b/...y/useConsistentGridAreas/invalid.css.snap → ...rsery/noInvalidGridAreas/invalid.css.snap
@@ -37,7 +37,7 @@ a { grid-template-areas: "a a a"
 
 # Diagnostics
 ```
-invalid.css:1:26 lint/nursery/useConsistentGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+invalid.css:1:26 lint/nursery/noInvalidGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! Empty grid areas are not allowed.
   
@@ -52,7 +52,7 @@ invalid.css:1:26 lint/nursery/useConsistentGridAreas ━━━━━━━━━
 ```
 
 ```
-invalid.css:2:26 lint/nursery/useConsistentGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+invalid.css:2:26 lint/nursery/noInvalidGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! Inconsistent cell count in grid areas are not allowed.
   
@@ -68,7 +68,7 @@ invalid.css:2:26 lint/nursery/useConsistentGridAreas ━━━━━━━━━
 ```
 
 ```
-invalid.css:4:33 lint/nursery/useConsistentGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+invalid.css:4:33 lint/nursery/noInvalidGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! Empty grid areas are not allowed.
   
@@ -87,7 +87,7 @@ invalid.css:4:33 lint/nursery/useConsistentGridAreas ━━━━━━━━━
 ```
 
 ```
-invalid.css:6:33 lint/nursery/useConsistentGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+invalid.css:6:33 lint/nursery/noInvalidGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! Duplicate filled in rectangle are not allowed.
   
@@ -106,7 +106,7 @@ invalid.css:6:33 lint/nursery/useConsistentGridAreas ━━━━━━━━━
 ```
 
 ```
-invalid.css:11:33 lint/nursery/useConsistentGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+invalid.css:11:33 lint/nursery/noInvalidGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! Duplicate filled in rectangle are not allowed.
   
@@ -125,7 +125,7 @@ invalid.css:11:33 lint/nursery/useConsistentGridAreas ━━━━━━━━
 ```
 
 ```
-invalid.css:15:33 lint/nursery/useConsistentGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+invalid.css:15:33 lint/nursery/noInvalidGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! Duplicate filled in rectangle are not allowed.
   
@@ -144,7 +144,7 @@ invalid.css:15:33 lint/nursery/useConsistentGridAreas ━━━━━━━━
 ```
 
 ```
-invalid.css:17:35 lint/nursery/useConsistentGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+invalid.css:17:35 lint/nursery/noInvalidGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! Duplicate filled in rectangle are not allowed.
   
@@ -163,7 +163,7 @@ invalid.css:17:35 lint/nursery/useConsistentGridAreas ━━━━━━━━
 ```
 
 ```
-invalid.css:21:35 lint/nursery/useConsistentGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+invalid.css:21:35 lint/nursery/noInvalidGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! Inconsistent cell count in grid areas are not allowed.
   
@@ -182,7 +182,7 @@ invalid.css:21:35 lint/nursery/useConsistentGridAreas ━━━━━━━━
 ```
 
 ```
-invalid.css:24:33 lint/nursery/useConsistentGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+invalid.css:24:33 lint/nursery/noInvalidGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! Duplicate filled in rectangle are not allowed.
   
@@ -201,7 +201,7 @@ invalid.css:24:33 lint/nursery/useConsistentGridAreas ━━━━━━━━
 ```
 
 ```
-invalid.css:27:33 lint/nursery/useConsistentGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+invalid.css:27:33 lint/nursery/noInvalidGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! Duplicate filled in rectangle are not allowed.
   

diff --git a/.../nursery/useConsistentGridAreas/valid.css → ...pecs/nursery/noInvalidGridAreas/valid.css b/.../nursery/useConsistentGridAreas/valid.css → ...pecs/nursery/noInvalidGridAreas/valid.css
diff --git a/...ery/useConsistentGridAreas/valid.css.snap → ...nursery/noInvalidGridAreas/valid.css.snap b/...ery/useConsistentGridAreas/valid.css.snap → ...nursery/noInvalidGridAreas/valid.css.snap
diff --git a/crates/biome_diagnostics_categories/src/categories.rs b/crates/biome_diagnostics_categories/src/categories.rs
@@ -159,7 +159,7 @@ define_categories! {
     "lint/nursery/useBiomeSuppressionComment": "https://biomejs.dev/linter/rules/use-biome-suppression-comment",
     "lint/nursery/useConsistentBuiltinInstantiation": "https://biomejs.dev/linter/rules/use-consistent-new-builtin",
     "lint/nursery/useConsistentCurlyBraces": "https://biomejs.dev/linter/rules/use-consistent-curly-braces",
-    "lint/nursery/useConsistentGridAreas": "https://biomejs.dev/linter/rules/use-consistent-grid-areas",
+    "lint/nursery/noInvalidGridAreas": "https://biomejs.dev/linter/rules/use-consistent-grid-areas",
     "lint/nursery/useConsistentMemberAccessibility": "https://biomejs.dev/linter/rules/use-consistent-member-accessibility",
     "lint/nursery/useDateNow": "https://biomejs.dev/linter/rules/use-date-now",
     "lint/nursery/useDefaultSwitchClause": "https://biomejs.dev/linter/rules/use-default-switch-clause",

diff --git a/packages/@biomejs/backend-jsonrpc/src/workspace.ts b/packages/@biomejs/backend-jsonrpc/src/workspace.ts
diff --git a/packages/@biomejs/biome/configuration_schema.json b/packages/@biomejs/biome/configuration_schema.json