Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy-from-table memory usage #12

Open
colinbrislawn opened this issue Feb 17, 2023 · 3 comments
Open

taxonomy-from-table memory usage #12

colinbrislawn opened this issue Feb 17, 2023 · 3 comments

Comments

@colinbrislawn
Copy link

I'm testing out the new GreenGenes! 💚

The taxonomy-from-table is currently being killed once it reaches about 50% memory usage on a 16 GB VM.

The introduction post warned about this

NOTE: Just like filter-features, this command right now will require around 8-10GB of memory.

It's possible my system is overly aggressive with memory management, but either way I'm interested in tracking this issue for all the folks with potatoes

@wasade
Copy link
Member

wasade commented Feb 17, 2023

Thanks, @colinbrislawn!

Ya at the moment the method is quite burdensome, even with the short cuts we already implemented. Its original implementation was much worse in memory... What I'm considering is representing the taxonomic data in a SQLite3 database which would avoid the resident overhead, and likely would not greatly impacting performance. My hope is to have this in for the next release which I'm currently working on the upstream pieces for.

Out of curiosity, is this something you'd have time and interest in working on?

@colinbrislawn
Copy link
Author

colinbrislawn commented Feb 17, 2023

Maybe. I've not worked with SQLite3 before so I'm not sure I'm the best fit.

I can help with testing or docs, but that's mostly done for this plugin.

@wasade
Copy link
Member

wasade commented Feb 17, 2023

Okay, no worries, totally understand!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants