Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a warning when a branch length option (e.g. ignore lengths; make ultrametric) doesn't actually change the tree #447

Closed
fedarko opened this issue Nov 17, 2020 · 0 comments · Fixed by #456
Assignees
Milestone

Comments

@fedarko
Copy link
Collaborator

fedarko commented Nov 17, 2020

Discussed with @gwarmstrong in #444 at #444 (comment). Basically, if the user has a tree that is already ultrametric, then clicking the "make ultrametric" option should show a warning -- and if the tree's nodes all already have the same length, then clicking "ignore branch lengths" should also show a warning (I thiiink that even if the uniform length is 2 or something the drawing will still look identical to the uniform length of 1 used under the hood in the layout computations, due to how the camera/etc are scaled).

I think the most likely cause of users running into this situation in practice will be Qemistree users coming in with ultrametric trees and wondering why the Make ultrametric option doesn't change anything. Fortunately, the UI for these options (esp. with the improvements coming soon in #444) should make this situation pretty obvious, so I don't think this is a very high-priority issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants