Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve str type, set fixed width on load, and set fixed with on update_ids #872

Merged
merged 2 commits into from
Mar 25, 2022

Conversation

wasade
Copy link
Member

@wasade wasade commented Mar 21, 2022

Improve handling of IDs.

  • set a fixed width on load from HDF5
  • set a fixed with on update of IDs
  • avoid forcing dtype=object on construction

These are done for the benefit of lower level optimizations where specificity of the dtype is high value.

@wasade wasade merged commit 3876827 into biocore:master Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant