Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xchat and hexchat #94

Closed
Foggalong opened this issue Aug 28, 2015 · 26 comments
Closed

xchat and hexchat #94

Foggalong opened this issue Aug 28, 2015 · 26 comments
Assignees

Comments

@Foggalong
Copy link
Contributor

It would be nice to add support for xchat and it's successor hexchat. Let me know if there's anything else you need :)

@bilelmoussaoui bilelmoussaoui self-assigned this Aug 28, 2015
@bilelmoussaoui
Copy link
Owner

I will do today ;)

@Foggalong
Copy link
Contributor Author

Thanks <3

@bilelmoussaoui
Copy link
Owner

It seems that the icons are not hardcoded hexchat/data/icons the icons are installed in /usr/share/icons/hicolor/scalable/apps/
Can you confirm that?

@Foggalong
Copy link
Contributor Author

I only have hexchat.svg in that folder and I believe it's the app icon version, not the tray icon

@bilelmoussaoui
Copy link
Owner

Are you using any plugin to have the tray icon?

@Foggalong
Copy link
Contributor Author

No, it just comes with the stock program :(

@bilelmoussaoui
Copy link
Owner

can you paste the ouput of cd / && sudo find -name *tray_highlight*; also a screenshot of /tmp/ or just the folder content

@Foggalong
Copy link
Contributor Author

Output of cd / && sudo find -name *tray_highlight*

  • /usr/share/icons/Numix/24x24/status/tray_highlight.svg
  • /usr/share/icons/Numix/22x22/status/tray_highlight.svg
  • /usr/share/icons/Numix/16x16/status/tray_highlight.svg
  • /home/josh/Code/numix/hidpi/base/Numix/22/status/tray_highlight.svg
  • /home/josh/Code/numix/hidpi/base/Numix/16/status/tray_highlight.svg
  • /home/josh/Code/numix/hidpi/base/Numix/24/status/tray_highlight.svg
  • /home/josh/Code/numix/base/Numix/24x24/status/tray_highlight.svg
  • /home/josh/Code/numix/base/Numix/22x22/status/tray_highlight.svg
  • /home/josh/Code/numix/base/Numix/16x16/status/tray_highlight.svg
  • /home/josh/Code/elementary/plus/elementaryPlus/status/24/tray_highlight.svg

Screenshot of /tmp/
screenshot_2015-08-28_13-45-56

@bilelmoussaoui
Copy link
Owner

what's inside sni-qt_python2.7.. ? if it has nothing to do with hexchat, paste the output of cd / && sudo find -name "hexchat"

@Foggalong
Copy link
Contributor Author

Nothing :(
screenshot_2015-08-28_14-06-14

Output of cd / && sudo find -name "hexchat"

  • /usr/bin/hexchat
  • /usr/lib/x86_64-linux-gnu/hexchat
  • /usr/share/lintian/overrides/hexchat
  • /usr/share/menu/hexchat
  • /usr/share/doc/hexchat
  • /home/josh/.files/config/hexchat
  • /home/josh/.config/hexchat

@bilelmoussaoui
Copy link
Owner

I didn't find any icon :( It's seems that hexchat will merge this brench soon appindicator
I think that icons should be named hexchat-tray but not sure if they will work :/
@wa4557 do you have any idea?

@Foggalong
Copy link
Contributor Author

Last work in February doesn't give me much hope for that branch :(

@bilelmoussaoui
Copy link
Owner

I will look install it in Ubuntu unity and see if i can get the icons name, i don't promise anything :/

@Foggalong
Copy link
Contributor Author

I've tried running cd / && sudo find . -wholename *tray_highlight* which is the name of the attention icon and it's not brought up anything. How have they hardcoded it into the binaries of the application? :(

@bilelmoussaoui
Copy link
Owner

I downloaded the deb file, extracted it and i think that the icons are hardcoded into the binaries of the application as you said :(

@Foggalong
Copy link
Contributor Author

I'll report that to the upstream and we can try and get this fixed.

@bilelmoussaoui
Copy link
Owner

I hope so

@Foggalong
Copy link
Contributor Author

@Foggalong
Copy link
Contributor Author

Just as an update on this, the icons in that directory need to be PNG

@bilelmoussaoui
Copy link
Owner

Okay, if i understand the icons need to be png but where i should copy the icons? in the doc they only mention that the icons must be in a seperate dir in the config directory but which directory?

@bilelmoussaoui
Copy link
Owner

If you can have the path to the directory were the icons must be copied i can fix this as soon as i've that ;)

@bilelmoussaoui
Copy link
Owner

Ops the directory must be named icons. I will do add that tomorrow ;)

@bilelmoussaoui
Copy link
Owner

Fixed in my latest commit , be sure that $HOME/.config/hexchat/icons/ do exists ;)

@Foggalong
Copy link
Contributor Author

@bil-elmoussaoui That directory doesn't get created when hexchat is installed so won't be there for the majority of users. Could you make it so that if the folder isn't there it's created? something like this

if not os.path.exists(userhome + "/.config/hexchat/icons/"):
    os.makedirs(userhome + "/.config/hexchat/icons/")

@bilelmoussaoui
Copy link
Owner

Done 👍
Can you symlink the icons in Numix into

tray_fileoffer.png, hexchat-fileoffer
tray_highlight.png, hexchat-highlight
tray_message.png, hexchat-message
hexchat.png, hexchat-indicator

@Foggalong
Copy link
Contributor Author

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants