Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why dark light? #7

Closed
andia89 opened this issue May 27, 2015 · 3 comments
Closed

Why dark light? #7

andia89 opened this issue May 27, 2015 · 3 comments
Labels
enhancement

Comments

@andia89
Copy link
Collaborator

andia89 commented May 27, 2015

Just a quick question:

Why do you make the differentiation between light and dark themes? Why don't you just replace both icons (for variety for example variety-indicator and variety-indicator-light). For me this seems to be an unnecessary option, the user shouldn't and doesn't care about
@bilelmoussaoui
Copy link
Owner

@wa4557 i did this for grive-tools, as the applications has two folders one for dark and the other one for the light indicators. But i will fix this soon by adding two versions of grive and each one will change different icons

@andia89
Copy link
Collaborator Author

andia89 commented May 27, 2015

Good idea!

@bilelmoussaoui
Copy link
Owner

This is fixed now, thank you for reporting this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andia89 @bilelmoussaoui