Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skype Notifications #59

Closed
Foggalong opened this issue Jul 9, 2015 · 21 comments
Closed

Skype Notifications #59

Foggalong opened this issue Jul 9, 2015 · 21 comments
Labels

Comments

@Foggalong
Copy link
Contributor

When Skype gets a notification it's reverting to the default icon with the little orange dot rather than the blue status icon that this script switches it to

@bilelmoussaoui
Copy link
Owner

I will need the result of ls -R /tmp/sni-qt_* so i can check if the icon names are correct or not

@Foggalong
Copy link
Contributor Author

I've found this unthemed icon with the name skype_18942_0fce05395e6040b3fd0838935b3aa115.png. I'm guessing there'll be one of these icon for each number, but that they only show up after they've been seen for the first time?
screenshot_2015-07-09_19-27-18

@bilelmoussaoui
Copy link
Owner

Qt indicator uses tmp folder to store the icons. The icons will be shown in tmp once they're used and will be removed when you close the application. For example in this case you've skype_x_y.png. In .local/share/sni-qt/icons/ you will need to create a folder name skype and put the icon y.png there. The x changes in /tmp/ whenever you reopen the application which makes it impossible to theme without the patched version of sni-qt. Can you check if 0fce05395e6040b3fd0838935b3aa115.png exists in .local/share/sni-qt/icons/skype/?

@andia89
Copy link
Collaborator

andia89 commented Jul 9, 2015

It does but is a symlink. Maybe symlinks are no good? I can reproduce this btw. :(

@bilelmoussaoui
Copy link
Owner

This should be fixed now :P

@andia89
Copy link
Collaborator

andia89 commented Jul 9, 2015

No. Symlinks aren't the problem (at least for me). The same thing happens if all files are regular files...
unbenannt

@bilelmoussaoui
Copy link
Owner

Symlinks were not the problem, remove everything in .local/share/sni-qt/icons/skype and run the script again. This issue is due to some icons that were symlinked to themselves

@andia89
Copy link
Collaborator

andia89 commented Jul 9, 2015

Nope. Same as before... A lot of symlinks are broken though in .local share/sni-qt/icons/skype

@bilelmoussaoui
Copy link
Owner

Can you paste the list of icons in tmp/sni-qt_skype?

Le 9 juil. 2015 à 19:35, wa4557 notifications@github.com a écrit :

Nope. Same as before...


Reply to this email directly or view it on GitHub.

@andia89
Copy link
Collaborator

andia89 commented Jul 9, 2015

The problem is this not /tmp but there are a lot of icons missing, to which symlinks are pointing to, which breaks a lot of symlinks.

I tried to figur out why this happens, but no luck so far

0d96a65d843060dab4836712307a256b.png
fd56304306a9b229dbdaf4cf7dc4cbc7.png
4fb7a30c39fb0b95f300952ad4df27dc.png

are missing. It seems that the script is not working for those :(

@bilelmoussaoui
Copy link
Owner

@wa4557 can you try it now?

@andia89
Copy link
Collaborator

andia89 commented Jul 9, 2015

Ok the problem was that the script somehow corrupted the source icons in the icon theme (how can this possibly happen, the script only reads the file?). Anyways after repairing those files in the icon theme it works now

@andia89
Copy link
Collaborator

andia89 commented Jul 9, 2015

Is it possible, that the script tried to symlink a symlink back to the icon theme, and therefore broke the icon? @Foggalong You have to remove everything from .local/share/sni-qt/ repair (i.e. overwrite) the icons in your icon theme and run the script again. Then it should work

@bilelmoussaoui
Copy link
Owner

This is somehow possible :/ Because those broken icons were symlinked to themselves

@bilelmoussaoui
Copy link
Owner

@Foggalong can you confirm this?

@bilelmoussaoui
Copy link
Owner

Is this fixed or not yet?

@Foggalong
Copy link
Contributor Author

I don't actually get enough notifications to actually test this :(

@bilelmoussaoui
Copy link
Owner

I will keep this open until you test it 👍

@Foggalong
Copy link
Contributor Author

First notification working! :D not sure if it works for if you have more than one notification though - don't know how high up Skypes icons for the counter go :/
screenshot_2015-07-16_17-53-51

@bilelmoussaoui
Copy link
Owner

Nice!! I will close this 👍

@andia89
Copy link
Collaborator

andia89 commented Jul 16, 2015

Skype doesn't have a real counter for notifications. Even for more messages only the orange "1" is displayed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants