Rambox Not Fixed

[Foggalong]

Specifications

• Hardcode-Tray version : 4.2
• Distribution : Fedora 27
• Gtk version : 3.22
• Inkscape version : 0.92.2 (5c3e80d, 2017-08-06)
• Application name : Rambox
• Application version : 0.5.13

Expected behavior and actual behavior

Expected: HC-T detects Rambox and changes the tray icon, actually doesn't detect it's installed. Location is still /opt/Rambox/.

Steps to reproduce the problem

1. Fresh install of the above software
2. Run sudo hardcode-tray
3. Or run sudo hardcode-tray --only rambox --path /opt/Rambox/

[bilelmoussaoui]

I have just tried the latest Rambox version and it works correctly for me. Can you copy/paste the logs?
No need to specify --path in this case.

[terencode]

@bil-elmoussaoui I'm also unable to apply it. What logs do you want?

[bilelmoussaoui]

They are stored on /tmp/Hardcode-Tray/

[terencode]

Here you go:
13-01-2018_16-24-53.log

Note: I'm using Arch Linux, rambox installed from the AUR.

[bilelmoussaoui]

@Foggalong Where did you get the package from?

@terencode Can you try using the latest master version? Should be fixed in my latest commit 👍

[Foggalong]

@bil-elmoussaoui I actually tested with two; the appimage and the rpm from the latest version on GH.

[bilelmoussaoui]

@Foggalong the appimage could not be patched at the moment... Its a sandboxed format !
I just tried the rpm and it works correctly fine

[Foggalong]

@bil-elmoussaoui On Fedora? This is my log 😢

13-01-2018_16-24-53.log

[terencode]

@bil-elmoussaoui I can't try it, I get this when trying to apply:

Traceback (most recent call last):
  File "/usr/bin/hardcode-tray", line 119, in <module>
    App.execute()
  File "/usr/lib/python3.6/site-packages/HardcodeTray/app.py", line 113, in execute
    apps = App.get_supported_apps()
  File "/usr/lib/python3.6/site-packages/HardcodeTray/app.py", line 103, in get_supported_apps
    application_data = Parser(db_file)
  File "/usr/lib/python3.6/site-packages/HardcodeTray/modules/parser.py", line 47, in __init__
    self._read()
  File "/usr/lib/python3.6/site-packages/HardcodeTray/modules/parser.py", line 93, in _read
    self._parse_icons(data["icons"])
  File "/usr/lib/python3.6/site-packages/HardcodeTray/modules/parser.py", line 125, in _parse_icons
    icon = Icon(icons[icon])
  File "/usr/lib/python3.6/site-packages/HardcodeTray/modules/icon.py", line 38, in __init__
    self._read()
  File "/usr/lib/python3.6/site-packages/HardcodeTray/modules/icon.py", line 80, in _read
    self.icon_size = self.get_icon_size(App.icon_size())
  File "/usr/lib/python3.6/site-packages/HardcodeTray/modules/icon.py", line 102, in get_icon_size
    multiple = int(icon_name[1].split("x")[0])
ValueError: invalid literal for int() with base 10: '1.25'

DEBUG INFO:

[DEBUG] 2018-01-13 19:09:33 DE not detected.
[DEBUG] 2018-01-13 19:09:33 Reading config file: /home/terence/.config/hardcode-tray.json
[DEBUG] 2018-01-13 19:09:33 Arguments/Icon Size: None
[DEBUG] 2018-01-13 19:09:33 Config/Icon Size: 24
[DEBUG] 2018-01-13 19:09:33 Arguments/Theme: Papirus
[DEBUG] 2018-01-13 19:09:33 Arguments/Conversion Tool: None
[DEBUG] 2018-01-13 19:09:33 Config/Conversion Tool: Inkscape
[DEBUG] 2018-01-13 19:09:34 Config/Blacklist: telegram,hangouts
[DEBUG] 2018-01-13 19:09:34 Path with condition: dropbox_callback /home/terence/.dropbox-dist/{dropbox}/images/hicolor/16x16/status/

[bilelmoussaoui]

Somehow there was an issue that I didn't seen before. But I have fixed that. You can pull the latest commit and build it. Otherwise you can try with sudo -E hardcode-tray --only rambox --apply

[terencode]

@bil-elmoussaoui nice thanks I was going to add it was introduced with e9730bc but you were faster ;)

[terencode]

@bil-elmoussaoui Everything working for me!

[bilelmoussaoui]

@terencode Perfect! Enjoy using a beautiful desktop 👍

[bilelmoussaoui]

@Foggalong The icons are stored in /opt/Rambox/resources/app.asar Can you make sure it's the case?

[Foggalong]

Yup 👍

[bilelmoussaoui]

@Foggalong Can you please run sudo -E hardcode-tray --only rambox.electron,rambox --apply? Or just add the hardcode-tray.json to $HOME/.config/ and put this content on it

{ 	
    "icons": {
        "theme": "Numix",
        "size": 24
}
}

This will ensure that the Numix theme will be used with 24 icons size instead of trying to detect it automatically. This will allow you to avoid settings --theme and --size argument every time.

Other configurations are possible, see here https://github.com/bil-elmoussaoui/Hardcode-Tray/blob/master/data/config.json

[Foggalong]

Hey look, our old friend is back!

Thankfully disappeared after restarting Rambox. Running sudo -E hardcode-tray --only rambox.electron,rambox --apply worked with the same HC-T version as the start, not the latest git, and without doing the thing about adding the hardcode-tray.json to $HOME/config/.

What does that mean the issue is? Detecting Rambox?

[bilelmoussaoui]

@Foggalong Nop the issue is about detecting the current theme :) if you run it using sudo hardcode-tray the theme won't be detected currently as the -E flag allows reading the values of the current user settings correctly :)

• You should never run hardcode-tray and the application is open :p especially with electron apps as we replace stuff on a binary file ;)

[Foggalong]

Ah okay. Any thoughts on the theme detection / logs you need?

[bilelmoussaoui]

Just what DE you're using?

[Foggalong]

Still XFCE/i3 :)

[bilelmoussaoui]

I will refactor that part of the code as of the next version. This is not an issue at all, but it needs some improvements as part of #397. So if you run the code without root permissions it should work as expected for detecting the system :)
I'm going to close this as the Rambox app works as expected after all

[Foggalong]

@bil-elmoussaoui Thinking back, didn't there use to be a warning if you ran the script without the required -E flag?

[bilelmoussaoui]

There wasn't, we can't detect that :( At least, I'm not aware of that