Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception raised in the DataPak helper #451

Closed
arifzeeshan opened this issue Oct 22, 2017 · 12 comments
Closed

Exception raised in the DataPak helper #451

arifzeeshan opened this issue Oct 22, 2017 · 12 comments

Comments

@arifzeeshan
Copy link

Specifications

  • Hardcode-Tray version : Hardcode-Tray: 4.1
  • Distribution : Manjaro
  • Gtk version : 3.22
  • Inkscape version : Inkscape 0.92.2 5c3e80d, 2017-08-06 if installed
  • Cairo version : `` if installed
  • Sni-qt version: `` if installed
  • Application name : Papirus
  • Application version : ``

Expected behavior and actual behavior

With sudo -E hardcode-tray --conversion-tool RSVGConvert --size 22 --theme Papirus
I get the following error

** (hardcode-tray:20008): WARNING **: Couldn't connect to accessibility bus: Failed to connect to socket /tmp/dbus-LjCeZlqjHo: Connection refused
Welcome to Hardcode-Tray!
Desktop Environment: Xfce
Scaling Factor: 1
Icon Size: 22
Icon Theme: Papirus
Conversion Tool: RSVGConvert
To Do: All
1 - Apply
2 - Revert
3 - Clear Backup Cache
Please choose:

@bilelmoussaoui
Copy link
Owner

It's not an issue at all

@arifzeeshan
Copy link
Author

How is this not an issue ? It doesn't work.

Please choose: 1
Applying now..


Traceback (most recent call last):
  File "/usr/bin/hardcode-tray", line 120, in <module>
    App.execute()
  File "/usr/lib/python3.6/site-packages/HardcodeTray/app.py", line 120, in execute
    delta = app.do_action(action)
  File "/usr/lib/python3.6/site-packages/HardcodeTray/modules/applications/application.py", line 151, in do_action
    self.install()
  File "/usr/lib/python3.6/site-packages/HardcodeTray/decorators.py", line 59, in wrapper
    func(app)
  File "/usr/lib/python3.6/site-packages/HardcodeTray/modules/applications/application.py", line 97, in install
    self.execute(Action.APPLY)
  File "/usr/lib/python3.6/site-packages/HardcodeTray/modules/applications/helpers/binary.py", line 51, in execute
    self.install_icon(icon, icon_path)
  File "/usr/lib/python3.6/site-packages/HardcodeTray/modules/applications/pak.py", line 66, in install_icon
    self.set_icon(icon, icon_path, png_bytes, True)
  File "/usr/lib/python3.6/site-packages/HardcodeTray/modules/applications/pak.py", line 48, in set_icon
    self.set_binary_file(path.join(str(icon_path), self.binary))
  File "/usr/lib/python3.6/site-packages/HardcodeTray/modules/applications/pak.py", line 44, in set_binary_file
    self.pak = DataPack(binary_file)
  File "/usr/lib/python3.6/site-packages/HardcodeTray/modules/applications/helpers/data_pack.py", line 32, in __init__
    self._read()
  File "/usr/lib/python3.6/site-packages/HardcodeTray/modules/applications/helpers/data_pack.py", line 66, in _read
    raise Exception
Exception

@bilelmoussaoui
Copy link
Owner

Well, that wasn't what you have mentioned in the content of the issue
..

@arifzeeshan
Copy link
Author

Since, I have mentioned now.

@bilelmoussaoui
Copy link
Owner

The issue was closed before. Please report the right issue content next time;

@bilelmoussaoui bilelmoussaoui changed the title ** (hardcode-tray:20008): WARNING **: Couldn't connect to accessibility bus: Failed to connect to socket /tmp/dbus-LjCeZlqjHo: Connection refused Exception raised in the DataPak helper Oct 23, 2017
@bilelmoussaoui bilelmoussaoui added this to the v4.1.1 milestone Oct 23, 2017
@topisani
Copy link

topisani commented Nov 6, 2017

I get this too, any ideas?

@sorrowless
Copy link

Have the same issue on latest ArchLinux installation.

@arifzeeshan
Copy link
Author

Well, after the last update of sni-qt, I no longer have this issue. But Chromium-dev icon is still not fixed.And Chrome doesn't launch which is an existing bug.

@bilelmoussaoui
Copy link
Owner

I'm pretty aware of this issue, but sadly I'm so busy these days to work on Hardcode-Tray. I will try to have some free time to do some fixes and create a new release 👍

@bilelmoussaoui
Copy link
Owner

Can anyone of you guys send me the resources.pak file that you can find in /opt/google/chrome by email at bil[dot]elmoussaoui[at]gmail[dot]com
So i can work on this issue as soon as i can
Thanks

@varlesh
Copy link
Collaborator

varlesh commented Nov 11, 2017

rename zip to pak:
resources.zip
Chrome 62.0.3202.89

@bilelmoussaoui
Copy link
Owner

The issue is due to an outdated version of our modified version of data_pack helper (used to extract and create the pak file format).
Here's where the exception is raised
https://github.com/bil-elmoussaoui/Hardcode-Tray/blob/559ea362dcbc8fbb84004c66072d2f7cc5807186/HardcodeTray/modules/applications/helpers/data_pack.py#L63-L65
And it's due to a non-supported version of Pak files, the version we support on stable is 4. The latest version of Chrome/Chromium uses a new version of pak files (version 5). Work already started, and there's still a small issue to fix; see here #411. So this issue should be fixed once I have fixed the other issue and created a new release.

For the time being, you can add google-chrome & chromium to the blacklist. See the README for more information about that.

I'm going to close this, as it's "already fixed" i just need to fix the other issue and create a hotfix release.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants