Update PPA #391
Comments
|
Yes. But not overly soon. I'm occupied until Thursday... |
|
Your commands in the README don't work.
|
|
If I create an empty folder called Please make sure that the commands are correct otherwise I cannot update the ppa. |
|
The commands do work. I just forgot to mention that you need meson > 0.40. You can upgrade to this version using pip. |
|
Ok, got it now. There might be an issue though, ppa with meson are apparently not supported... Will further investigate |
|
Thank you very much!!! I will take a look too as soon as I can |
|
@bil-elmoussaoui I think figured out how to do it, however on launchpad they use an older meson version. Can you change the meson.build files such that the also work with lower versions? |
|
@wa4557 older versions doesn't work as expected with gettext for translations... I will take a look anyway. Launchpad is really the worst tool ever invented in the history of Linux. |
|
My packaging skills are also only ...semi good... |
|
As expected the packaging does not work with the provided If we would be able to change the meson version, I guess it would work |
|
@wa4557 I will try to get this to work or at least provide a patch for the PPA |
|
I asked on AskUbuntu https://askubuntu.com/questions/936337/build-launchpad-ppa-packages-with-backport-version Building on trusty won't be possible though, because in trusty there is no meson package |
|
i think better solution for all distros - it's appimage package - portable and worked on all distros... but only we need patched sni-qt library on deb's |
|
Providing an AppImage would have, among others, these advantages:
Here is an overview of projects that are already distributing upstream-provided, official AppImages. |
|
@probonopd I don't know how AppImage works internally. But the case here is the app(cli here) runs only from terminal and must have access to the user's file system. Can be this done using AppImage? |
|
Yes. |
|
Alright, i will see what i can during this week/weekend. I might need some help. Do you mind if a ping you or is there an official iirc where i can get some help? |
|
Sure, either ask me here or drop by #AppImage on irc.freenode.net |
|
Even thoug an AppImage would be great I still think that a working PPA would make sense. @bil-elmoussaoui I think the issue is that there is no "build" command in meson.build. Because the install thing is not what is needed for building the deb file. Can you look into that? Here the logfile of the (failed) build |
|
@wa4557 Sorry for the delay. I think you forgot to copy/paste the logfile content here :P |
|
By taking a look at the current PPA build status, i think i might have figured out how to fix that issue. I'm forcing to install the content of the database files into /opt/HardcodeTray but that won't work for fake root. I have fixed that on my alpha branch, but there are few things to be fixed there before i can merge into the master branch. i will try to do that before the weekend and hopefully, we will get the latest release on the PPA! 👍 |
|
@bil-elmoussaoui Cool. But you must not update meson to 0.41 otherwise a PPA won't work! The latest version of meson in Trusty/Xenial is 0.40.1. So if your script also works with 0.40 we have to keep it |
|
I will not, we don't use any new features from 0.41 (the latest thing we use the python module on Meson which was released with the 0.40 version http://mesonbuild.com/Python-3-module.html) |
|
Was just looking at your commit messages. It says 0.41 :) |
|
It must be a typo (see https://github.com/bil-elmoussaoui/Hardcode-Tray/blob/alpha/meson.build#L3) |
|
is the alpha branch already usable? Wanna try if packaging works |
|
Yep should work as expected 👍 |
|
it must be |
|
Got it it's I don't understand why for building a package we need to put something in |
|
@wa4557 I think that you might need to use the --prefix argument somewhere? as I don't force installing on /usr/lib at all see |
|
So which |
|
Never mind, I get a new permission error now |
|
It depends on the Python version shipped with the Ubuntu version :/ The python path is detected automatically thanks to Meson. For the /usr/local/share i don't see what it's saying that there's a permission error :/. That shouldn't be a problem? |
|
As a normal user I can't install to |
|
Nop, normal users can't install any deb file at all... |
|
But for packaging, you should be able to create /usr/share/Hardcode-Tray/ without any issue as launchpad build system uses a fake root |
|
But still I should be able to build the deb file. Oh boy I know so little about packaging, just trying random stuff :) |
|
Can you have a look at this? They seem to have a working https://bazaar.launchpad.net/~ztefn/haguichi/meson-build/view/head:/meson.build |
|
Hey the problem isn't on meson :P As i have switched recently Lollypop from Autotools to Meson and the build works just fine. It seems that they use something like this for the nina -C install |
|
Yes I guess you're right. Now I need to find the |
|
@wa4557 #!/usr/bin/make -f
override_dh_auto_clean:
rm -fr build
override_dh_auto_configure:
mkdir -p build
cd build && meson .. --prefix=/usr
override_dh_auto_build:
cd build && ninja -v
override_dh_auto_test:
cd build && ninja test
override_dh_auto_install:
DESTDIR=$(CURDIR)/debian/lollypop ninja -C build -v install
%:
dh $@ |
|
Got it working :) Can I change the file in the master branch? |
|
Nevermind you already merged, awesome |
|
What's the next step? Should i create a new release to trigger the PPA update? |
|
One thing, though. It's not possible to build the package for trusty. No meson package exists in trusty... |
|
@bil-elmoussaoui Already building. That's ok its adaily build anyways |
|
Trusty doesn't have the needed version of Ninja either + it's not supported anymore. People should upgrade to 16.04 or build from source code by installing meson using |
|
Wait a moment, I get a few warnings during build. Might be worth looking into: |
|
|
|
What about the location of the python module? |
|
I've just downloaded the latest deb, extracted it and everything seems to be okey. I don't have an Ubuntu machine at the moment to try it |
|
It's not ok. Ubuntu does not recognize the installed python module... |
|
i've tried the latest package in elementary OS and everything is installed correctly except the executable file... |
|
@wa4557 Should be fixed now 5250d09 |
|
Cool, I'll check it out. I don't know why the executable is not installed, though... |
|
Thanks for your work on this @wa4557. We have finally got a working PPA again :P |
I've just pushed a new release which introduces translations and few bugs fixes
In order to get translations to work, i had to use a build system (Meson here). And I've also removed the update & update-git options as it's now easier to update the script using meson.
The PPA should be updated to use meson build system. I've added the build commands to the README.
@wa4557 Do you think that you will have some free time to take a look at this? My Debian packaging skills are close to 0
The text was updated successfully, but these errors were encountered: