Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to contribute, but I am overlooking something #348

Closed
rpbaptist opened this issue Apr 28, 2017 · 3 comments
Closed

Trying to contribute, but I am overlooking something #348

rpbaptist opened this issue Apr 28, 2017 · 3 comments

Comments

@rpbaptist
Copy link

Specifications

  • Hardcode-Tray version : master branch
  • Distribution : Ubuntu 16.04.2
  • Gtk version : ``
  • Inkscape version : 0.91 r13725
  • Cairo version : 1.0.19
  • Sni-qt version: 0.2.7+20161212~10~ubuntu16.04.1
  • Application name : copyq
  • Application version : v2.9.0

I added the following JSON locally:

// database/copyq.json
{
    "name": "CopyQ",
    "app_path": [
        "/usr/bin/copyq",
        "/usr/lib/copyq/"
        "/usr/share/copyq/"
    ],
    "icons_path": [
        "/usr/share/hicolor/{size}/apps/"
    ],
    "is_qt": false,
    "is_script": false,
    "force_create_folder": false,
    "exec_path_script": false,
    "backup_ignore": false,
    "icons": [
        "copyq-normal.svg",
        "copyq-busy.svg"
    ]
}

I tried with icons_path /usr/share/hicolor/scalable/apps/ as well. I tried with and without extensions.

This is the output after running the script:

> ./hardcode-tray --conversion-tool Inkscape --dark-theme Papirus --size 24 --only copyq
Welcome to the tray icons hardcoder fixer!
Your indicator icon size is : 24
The detected desktop environement : Other
Your current icon theme is : Papirus-Dark
Conversion tool : Inkscape
Applications will be fixed : Copyq
1 - Apply
2 - Revert
Please choose: 1
Applying now..

No apps to fix! Please report on GitHub if this is not the case

I would be happy to contribute, but I am missing something which I cannot find in the wiki. I tried the same for the insync application and see the same result.

@bilelmoussaoui
Copy link
Owner

If the original icons are on /usr/share/icons/hicolorHardcode-Tray is not needed at all... as those icons are not hardcoded, it must be your theme that doesn't provide those icons.

@rpbaptist
Copy link
Author

Strange, because it does have the icons. I suppose it's an issue for Papirus then.

@bilelmoussaoui
Copy link
Owner

Feel free to reopen this if you have any other questions or any help =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants