Icons are too small, and not crisp -- Plasma #300
Comments
|
on plasma used only 22px for tray |
|
@varlesh are you acknowledging a part of the problem that needs fixing, or stating that the behavior is as intended? |
|
@AndydeCleyre You just need to use |
|
Ping? |
|
@bil-elmoussaoui This is what it looks like after hardcode-tray --theme Papirus-Dark --size 22 -a
|
|
As i've never used KDE before, what does this [Containments][6][General]
iconSize=2? |
|
Yes, it changes the size of tray icons; see https://www.reddit.com/r/kde/comments/55yyia/kde_58_system_tray_icons_small/ |
|
Ah so you have a high DPI screen? If it's case, I think that you should try with a much higher size like 48 or something like that ;) anyway it's not supported at the moment as I've limited the sizes to 16, 22, 24! I would like to implement a proper support for that if you can test it :) I will create a test branch just for you . Are you Okey with that ? |
|
I don't have any high dpi screens, just 1920x1080. I'm happy to test anything. |
|
Ok, i will need you to estimate the size of the other icons that looks correctly on your screen. Is the |
|
I'm not sure, I'll see if I can find out later. In my own scripts to replace the telegram icons, I just rendered an svg as 256x256 pngs, and that looked fine to me. |
|
I can't just render 256x256 pngs for everyone ;) I will have to get this done only when needed! For now, i'm quite busy! i will give it a shot (i will install KDE for the first time on my life!). Should be done by the end of this month 👍 |
|
Here's the result of hardcode-tray --theme Papirus-Dark --size 256 --change-color "#d3dae3 #c2b790" -a
Maybe related to the comment from @varlesh , still waiting to hear back from him on the 22px business. |
|
Papirus svg-based icon theme. SVG - vector image. What you want from me? |
|
@AndydeCleyre Tray icons on Plasma used only 22px, see sources on Breeze. More icons contained on plasmashell theme - volume, klipper, network and etc... |
|
For non-blurred icons need reduce panel size, because on Papirus available only icons for 22px and 24px. |
|
@AndydeCleyre Ok, I just did some research and it seems that KDE will scale whatever icons you're using to a different size. So if you're using Png icons with the right size that should be used, they will be scaled up/down whatever it's original size which makes them look blurry... |
|
Well I don't want to disable the scaling, because I want to control the size of the icons (and have them big). I don't think it's a bug that you can control the icon size in a plasma panel. |
|
No, it's not a bug! it's just i don't have a screen that i can scale correctly to debug this. Anyway, normally it should look good with 44px as the normal size on KDE is 22px, can you try doing that ? are this configuration stored somewhere else ? |
|
I've added scaling factor detection on the latest version on master. Please check this out, thanks! |
|
With
The hexchat and slack icons still look small to me, but it's not a big deal. If I want them to be unpixelated, though, is that dependent on |
|
Can you add this line of code |
|
Sure, it reports When I leave out the theme argument and it picks When I specify the theme When I specify
Specifying |
|
Alright it seems that the scaling factor is not detected correctly :( I will investigate this. I will submit a patch pretty soon. I will need just one last information, can you add after this line https://github.com/bil-elmoussaoui/Hardcode-Tray/blob/master/modules/utils.py#L95 this line of code |
|
I've found that this line sets the scaling factor to |
|
I see thanks for the help! i will get this done in few minutes. |
|
@bil-elmoussaoui I notice: $ echo $DESKTOP_SESSION
/usr/share/xsessions/plasmaBut that's probably different for a wayland user, at least. $ echo $XDG_CURRENT_DESKTOP
KDE
$ echo $KDE_SESSION_VERSION
5So it looks to me like checking |
|
@AndydeCleyre I will take care of that this week ;) |
|
@AndydeCleyre I've implemented the desktop session check on the beta branch. Would you mind testing it so i can be sure that everything works as expected? A new version will be released by the end of the week. I would be really thankful if you can test this feature :) |
|
@bil-elmoussaoui Thanks. With the hardcode-tray -a --change-color "#d3dae3 #c2b790" --theme Papirus-Darkreports The size actually looks ok in the panel (just not the resolution). |
|
@AndydeCleyre Does Hardcode-Tray report the current desktop env? it should be shown in the output too! A screenshot would be great too so i can take a look at it 👍 |
|
@bil-elmoussaoui Ah, yes, the desktop is correctly identified:
|
|
Ok that's pretty great :) can you send me a log file, it's under /tmp/Hardcode-Tray/ just paste it here, it might help me debug why the icon size is not detected correctly |
|
Here's the latest log file in that folder (ah, that first line is interesting): |
|
@AndydeCleyre The kde not detected debug msg was sent by the get_scaling_factor function, i added an other debug msg to seee what causes this issue. Can you pull the latest changes and try again? This should output more information about this issue. |
|
The sectioning of that kde config file is weird: |
|
Alright, it seems that i can't read that file using ConfigParser (to read ini files). I will use a simple file reading and regex on it to get the iconSize |
|
@AndydeCleyre My latest commit should fix this now :) |
|
|
It was a typo, fixed! |
|
Oooh. I can't see a difference in the icons (I think that I need to follow up with the papirus theme to understand how to handle this), but: Do you still want to see a log, or does that seal the deal? |
|
I would like to take a look to be sure that everything works okey ;) + Woud like to know which value was assigned to iconSize in your current configuration |
|
It's currently Looks like it's grabbing the wrong |
|
But it won't be the only match. Actually here's a grep-friendly regex: At least for me, only one of the sections matching that has an |
|
Alright, i thought that it must be defined only once :) It should be correctly detected now :) |
|
Thanks, it seems to find the right setting now. The output is a little crazy: |
|
Perfect! It was a debugging output that i've frogot to remove; it's removed now :) If you have any other issue with that, it should be reported upstream now :) thanks for your patient! |
|
Thank you so much for working through this, and for this project. |
|
My pleasure ;) |
|
Hello! I don't think this is really working yet.
hardcode-tray -a --change-color "#d3dae3 #c2b790" --theme Papirus-Darkmediainfo .TelegramDesktop/tdata/ticons/ico_22_1.png|grep pixelsmediainfo .config/hexchat/icons/hexchat.png|grep pixelsmediainfo /usr/lib/slack/resources/app.asar.unpacked/src/static/slack-taskbar-unread.png|grep pixels |
|
I'm currently using this for better results: icon_size="512"
main_color="#c2b790"
accent_color="#a94d37"
main_color_old="#d3dae3"
accent_color_old="#5294e2"
tg_icons="$HOME/.TelegramDesktop/tdata/ticons"
tg_tmp="/tmp/tg_svgs"
mkdir -p ${tg_tmp} ${tg_icons}
for i in '_22':'' '_22_1':'attention-' 'mute_22_0':'' 'mute_22_1':'mute-'; do
ico=${i%:*}; name=${i#*:}
sed "s/${main_color_old}/${main_color}/gi" ${panel_icons}/telegram-${name}panel.svg > ${tg_tmp}/telegram-${name}panel.svg
sed -i "s/${accent_color_old}/${accent_color}/gi" ${tg_tmp}/telegram-${name}panel.svg
inkscape -z -e ${tg_icons}/ico${ico}.png -w ${icon_size} -h ${icon_size} ${tg_tmp}/telegram-${name}panel.svg &>/dev/null
done
for f in {2..2000}; do
ln -sf ${tg_icons}/ico_22_1.png ${tg_icons}/ico_22_${f}.png
ln -sf ${tg_icons}/icomute_22_1.png ${tg_icons}/icomute_22_${f}.png
done
slack_icons="/usr/lib/slack/resources/app.asar.unpacked/src/static"
slack_tmp="/tmp/slack_svgs"
mkdir -p ${slack_tmp}
for i in '':'rest' '-unread':'unread' '-unread':'highlight'; do
ico=${i%:*}; name=${i#*:}
sed "s/${main_color_old}/${main_color}/gi" ${panel_icons}/slack-indicator${ico}.svg > ${slack_tmp}/slack-taskbar-${name}.svg
sed -i "s/${accent_color_old}/${accent_color}/gi" ${slack_tmp}/slack-taskbar-${name}.svg
inkscape -z -e ${slack_tmp}/slack-taskbar-${name}.png -w ${icon_size} -h ${icon_size} ${slack_tmp}/slack-taskbar-${name}.svg &>/dev/null
sudo cp ${slack_tmp}/*png ${slack_icons}/
done
hex_icons="$HOME/.config/hexchat/icons"
hex_tmp="/tmp/hex_svgs"
mkdir -p ${hex_icons} ${hex_tmp}
for i in 'indicator':'hexchat' 'highlight':'tray_fileoffer' 'highlight':'tray_highlight' 'highlight':'tray_message'; do
ico=${i%:*}; name=${i#*:}
sed "s/${main_color_old}/${main_color}/gi" ${panel_icons}/hexchat-${ico}.svg > ${hex_tmp}/${name}.svg
sed -i "s/${accent_color_old}/${accent_color}/gi" ${hex_tmp}/${name}.svg
inkscape -z -e ${hex_icons}/${name}.png -w ${icon_size} -h ${icon_size} ${hex_tmp}/${name}.svg &>/dev/null
done |
|
I will take a look this evening ;) thanks for trying this out, as i don't have a HDPi screen to test it |
|
No problem, but as I've mentioned, I don't have any high dpi screens either. |
|
@AndydeCleyre Hey, I have released a new version yesterday; You will have to reinstall it as there was a lot of changes. it should now work as expected as i have fixed few issues with the conversion from SVG to PNG. The icons are scaled up only for PNG ones, as i can't rescale SVG ones (done automatically normally...) |
|
Hi, I've just tried with |
|
@AndydeCleyre I will need more info to debug this, can you join the chat on Gitter and see how we can fix this 👍 |
Specifications
3.6.5Arch3.22.60.92.01.14.8Nonehexchat,telegram,slack2.12.4,1.0.0,2.3.4Expected behavior and actual behavior
Expected icons that match the other panel icons in size and quality.
Actual results:
Steps to reproduce the problem
.config/plasma-org.kde.plasma.desktop-appletsrcI haveThe text was updated successfully, but these errors were encountered: