electron apps black icons

[varlesh]

hardcode-tray git version
icon theme: ePapirus
inkscape: 0.91
on elementaryOS loki applied black icons for electron apps.
LOG:

hardcode-tray -s 24 -fs
Welcome to the tray icons hardcoder fixer!
Your indicator icon size is : 24
Your current icon theme is : ePapirus
Svg to png functions are : Enabled
Applications will be fixed : All
1 - Apply
2 - Revert
Please choose: 1
Applying now..

Clementine               [#.......................................] 1/34 2.9%
Google Chrome            [##......................................] 2/34 5.9%
Skype                    [######################################..] 32/34 94.1%
Wire                     [########################################] 34/34 100.0%

Tested with skype4linux and wire:

[varlesh]

icon converted with inkscape to white color by manual fine. For example:

inkscape -z -f wire-tray.svg -e wire-tray.png

@bil-elmoussaoui What happened again?

[varlesh]

also script change premissions to ROOT on inkscape config home user folder ~/.config/inkscape

[varlesh]

it's happened with only electron apps. Telegram, Clementine worked fine:

[bilelmoussaoui]

Even when you try --force-inskcape ? For the config folder of inkscape, i will see what i can do about it. It must be due to running inkscape as root (which shouldn't btw causes this..)

[varlesh]

Even when you try --force-inskcape ?

Yes, i'm attach log and doing this repeatedly - electron apps not use inkscape, because icon black.
also option revert not worked - status show OK, but really icons not reverted.

[varlesh]

@bil-elmoussaoui maybe better use inkscape for all (by default) and remove cairo? Because cairo bugged :(

[bilelmoussaoui]

It's impossible that electron apps won't use inkscape instead of cairo. I will try to investigate more about this tomorrow morning. Are you using elementary OS? and where i can find the theme you're using?

[varlesh]

Ok, thank you!
it's Papirus mod for elementary...

wget -qO- https://raw.githubusercontent.com/PapirusDevelopmentTeam/papirus-icon-theme/master/install-papirus-root.sh | sh

[varlesh]

@bil-elmoussaoui any news?

[bilelmoussaoui]

@varlesh I just installed elementary OS again, tried installing skypeforlinux but the tray icons are not working on elementary at all... do you have any idea?

[varlesh]

need install libs:
sudo apt install libappindicator1 python-appindicator libappindicator3-1 libindicator3-7 libindicator7 wingpanel-indicator-ayatana

[bilelmoussaoui]

Ok i got the indicators now, and i got the dark icons too. It seems that inkscape does not convert icons right. As when i use --force-inkscape, it uses inkscape as expected (did some tests). I will try to extract the asar file and see if the icons are black or white..

[varlesh]

No, inkscape worked right, because i'm convert icon manual:
inkscape -z -f input.svg -e output.png
And for other apps (not electron) all worked fine.
extract not needed - icons available on /tmp - chromium folders

[varlesh]

it's happened with electron apps only and i don't know why...

[varlesh]

i think script not use inkscape for electron or maybe electron.py have error

[bilelmoussaoui]

You're right! the issue is from electron.py i guess.. as i forgot to add the --force-inkscape to the electron script. I will add a hacky solution to fix this, a better fix will land with #248

[bilelmoussaoui]

Fixed! i've also fixed the same issue with chrome and spotify script. This issue shouldn't happen at all never again with the new version of the code!

[varlesh]

revert worked too?

[bilelmoussaoui]

Yes it works perfectly on my computer. You must have corrupted the bak file that's why it doesn't revert to the right file. I'm thinking of a better backup revert feature. Like having the backup saved by date and time so you can have multiple versions saved. All of those saved on .config/hardcode-tray. For now, all i can tell you is reinstall the application to get the default asar file back and apply the script again. It should work fine.

[varlesh]

@bil-elmoussaoui Big thx!!! All fine:

[bilelmoussaoui]

Happy to hear that it works! stay tuned, the new release will add some nice features!