Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lantern and alkasir icon #228

Closed
Chamrosh opened this issue Nov 26, 2016 · 4 comments
Closed

add lantern and alkasir icon #228

Chamrosh opened this issue Nov 26, 2016 · 4 comments

Comments

@Chamrosh
Copy link

Chamrosh commented Nov 26, 2016

https://getlantern.org/
https://alkasir.com/en/

@bilelmoussaoui
Copy link
Owner

I just built lantern on my desktop. The icon is stored under /tmp with the name systray_rjbgJW. As the file will be removed once the application is closed, this will make it impossible to theme only if i can access to the source code of the application.I will clone the source code and investigate.

@bilelmoussaoui
Copy link
Owner

bilelmoussaoui commented Nov 26, 2016

This is sadly hardcoded. As you can see here https://github.com/getlantern/lantern/blob/devel/src/github.com/getlantern/systray/systray_linux.c#L41
This https://github.com/getlantern/lantern/blob/devel/src/github.com/getlantern/systray/systray_linux.c#L45 will generate a unique icon name.
The icon is received a bytes data. https://github.com/getlantern/lantern/blob/devel/src/github.com/getlantern/systray/example/icon/iconunix.go
The only solution in order to fix this is creates a PR to use an indicator icon from the default theme. My C/C++ coding skills are not that good! but it should be easy to fix this; I will open a PR upstream and hope it will get merged soon

@bilelmoussaoui
Copy link
Owner

Tried to fix both issues but compiling those applications is really a pain. Reported on both projects upstream and also provided the c++ documentation on how to fix this.
Closing this, hope they will fix it as soon as possible 👍

@bilelmoussaoui
Copy link
Owner

If you wish to get any more information about both issues here they are: https://github.com/getlantern/lantern/issues/5473
alkasir/alkasir#86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants