Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use json instead of csv #197

Closed
bilelmoussaoui opened this issue Nov 7, 2016 · 9 comments
Closed

Use json instead of csv #197

bilelmoussaoui opened this issue Nov 7, 2016 · 9 comments

Comments

@bilelmoussaoui
Copy link
Owner

As discussed here #196
I think it's time to move to a more readable database by us and a way to make adding new icons more easier.
I started moving some database files in the json branch, if you have some free time a help will be much appreciated. Once all the files are using the new format, i will modify the script to read the json files instead of the csv files. Shouldn't be hard, but i will try to make all the stuff use the json file and we won't have to treat each application differently on the python script (reduce the number of the scripts).

CC: @wa4557

@bilelmoussaoui
Copy link
Owner Author

Quick update : finished converting all csv files to json, was the hardest task till now :p i will have to check every file if the json syntax is correct. once everything is okay, i will update the script which shouldn't be complicated

@andia89
Copy link
Collaborator

andia89 commented Nov 8, 2016

Great, I might have some freetime this weekend, if there's still something left to do then :P

@bilelmoussaoui
Copy link
Owner Author

I have some free time today, i will see if i can fix everything and release a new version ! :P

@bilelmoussaoui
Copy link
Owner Author

@wa4557 it's working pretty well now, i just need to modify the revert code. I've removed the google chrome notification center support as it's removed in the latest versions of chrome, and it was causing too many issues, and a lot of lines codes...People will just have to upgrade their browser ;)
I couldn't manage to integrate the dropbox path into the json file, i modified the code a little bit to have fewer lines of code, it works well but it's not the best solution i guess.
Will release a new version tomorrow if everything works fine. It would be really nice if you can try the json branch and report back

@andia89
Copy link
Collaborator

andia89 commented Nov 9, 2016

Looking good to me. Wasn't able to find any breakage so far. Will have a look into the code a bit later...

EDIT: One error

fixing failed with error:
    /home/andreas/Diverses/Hardcode-Tray/database/scripts/spotify: line 8: cd: /opt/Hardcode-Tray/dataoriginal/scripts: No such file or directory
    python3: can't open file 'svgtopng.py': [Errno 2] No such file or directory

EDIT2: Can we remove the chrome scripts? Can we outsource the dropbox stuff to a seperate script (a more modular approach)

@bilelmoussaoui
Copy link
Owner Author

I will see how to fix the issue. We still need chrome script, as i've only removed the icons that were used by the notification center; But chrome still have a tray icon, the get_correct_chrome_icons were used by the notification center, also the chrome images we had in the database folder. I don't know how we can really fix the dropbox issue :( if you have any idea feel free to tell me about it 👍

@bilelmoussaoui
Copy link
Owner Author

Moved the dropbox code to a new script "dropbox", and added a new key to the json files, that have a script that will be executed on the application path.

@rpbaptist
Copy link

I was wondering where the CSV database file was. The documentation on how to contribute still refers to that, but this clears it up.

@bilelmoussaoui
Copy link
Owner Author

@rpbaptist i need to modify the documentation as too many things changed since the latest version... but the new code is more easy to understand than before ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants