Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Teamviewer 11 support #126

Closed
bilelmoussaoui opened this issue Dec 16, 2015 · 29 comments
Closed

Add Teamviewer 11 support #126

bilelmoussaoui opened this issue Dec 16, 2015 · 29 comments

Comments

@bilelmoussaoui
Copy link
Owner

It's seems that Teamviewer 11 have a tray icon now. I think it's a Qt icon;
but i can use it in Fedora 23, i don't know why.
@wa4557 @Foggalong Any one of you is using Ubuntu or XFCE to help me get the icon name ? 👍

@andia89
Copy link
Collaborator

andia89 commented Dec 16, 2015

No icons in /tmp. I don't think it's a QT application

@bilelmoussaoui
Copy link
Owner Author

It's Qt wine application..The only icon installed by the application is in /opt/teamviewer/tv_bin/desktop/ can you confirm that?

@bilelmoussaoui
Copy link
Owner Author

And in this folder opt/teamviewer/tv_bin/RTlib/plugins/systemtrayicon you can find the plugin for the tray icon. I looked at the code, and application do create a folder in /tmp for Qt icons

@andia89
Copy link
Collaborator

andia89 commented Dec 16, 2015

This: opt/teamviewer/tv_bin/RTlib/plugins/systemtrayicon does not exist on my machine. And no there is nothing in /tmp

@bilelmoussaoui
Copy link
Owner Author

In my case i have this folder sni-qt_TVGuiDelegate_10300-0nRVI4But there's nothing in the icons folder :/ I tried changing the icon in /opt/teamviewer/tv_bin/desktop/ but that does not change the icon too. I think that the icon is hardcoded in the binary file..

@andia89
Copy link
Collaborator

andia89 commented Dec 17, 2015

Yeah I don't have that folder :( Changing the icon doesn't help in my case either...

@bilelmoussaoui
Copy link
Owner Author

Will keep it open, maybe something will change later..

@andia89
Copy link
Collaborator

andia89 commented Dec 19, 2015

Ok my fault I wa still having teamviewer 10 installed. For teamviewer 11 I have those icons in /tmp
unbenannt

TVGuiDelegate_30638_0b040b0d9ec00ce0d8189ece93cd2b7f.png
TVGuiDelegate_30638_4327113cab136a09fac832e66878159a.png
TVGuiDelegate_30638_54b99333baa6a26fda3eb8ce6d664bd5.png

@bilelmoussaoui
Copy link
Owner Author

Haha:P
What do you think about those names?

0b040b0d9ec00ce0d8189ece93cd2b7f.png, teamviewer-indicator, qt-tray
54b99333baa6a26fda3eb8ce6d664bd5.png, teamviewer-indicator-error, qt-tray
4327113cab136a09fac832e66878159a.png, teamviewer-indicator-connected qt-tray

@andia89
Copy link
Collaborator

andia89 commented Dec 19, 2015

👍

@bilelmoussaoui
Copy link
Owner Author

Fixed in 2ca7031
Thanks 👍

@andia89
Copy link
Collaborator

andia89 commented Dec 19, 2015

Can you post the output of the code for the trayicon-lugin (maybe pastebin)? (opt/teamviewer/tv_bin/RTlib/plugins/systemtrayicon) Still does not exist on my machine, and I'm trying to find out the name of the plugin, to put it in the right position on the tray...

@bilelmoussaoui
Copy link
Owner Author

You can download the deb file from the website, and extract it you will find the file, i can't copy/paste the content file as it's .so file.. :/

@andia89
Copy link
Collaborator

andia89 commented Dec 19, 2015

And how to look at the code then?

@bilelmoussaoui
Copy link
Owner Author

You will need to use a Hex editor :s (Bless Hex Editor is a good one!)

@andia89
Copy link
Collaborator

andia89 commented Dec 19, 2015

Ah yeah sure. Thx :)

@andia89
Copy link
Collaborator

andia89 commented Dec 20, 2015

There is another icon... TVGuiDelegate_28264_c28d37df9872311f7c6b295b70b8a39d

unbenannt

@bilelmoussaoui
Copy link
Owner Author

Added as teamviewer-indicator-paused, but i don't know if it's the right name; when this icon is being used?

@andia89
Copy link
Collaborator

andia89 commented Dec 20, 2015

I guess idle would be better or away or inactive

@bilelmoussaoui
Copy link
Owner Author

changed that to idle 👍

@andia89
Copy link
Collaborator

andia89 commented Dec 20, 2015

Designing those icon will be hard :/

@bilelmoussaoui
Copy link
Owner Author

Like a lot of status icons.. As nobody is using them, there's no reason to include them in Numix base theme ;)

@bilelmoussaoui
Copy link
Owner Author

#91 are the hardest ones to do !

@andia89
Copy link
Collaborator

andia89 commented Dec 20, 2015

Well I am using them, so I have an interest in adding them + teamviewer is actually a program widely used :)

@bilelmoussaoui
Copy link
Owner Author

You can use only the double arrow as a base icon ?

@andia89
Copy link
Collaborator

andia89 commented Dec 20, 2015

Oh come one...

TVGuiDelegate_28264_0b040b0d9ec00ce0d8189ece93cd2b7f.png
TVGuiDelegate_28264_4327113cab136a09fac832e66878159a.png
TVGuiDelegate_28264_4cd9545d0021db224685d863ac738f91.png
TVGuiDelegate_28264_54b99333baa6a26fda3eb8ce6d664bd5.png
TVGuiDelegate_28264_86e4f5bf63a6fa1725afd2e08e0ce105.png
TVGuiDelegate_28264_c28d37df9872311f7c6b295b70b8a39d.png

unbenannt

new icons should be offline, and busy...

@bilelmoussaoui
Copy link
Owner Author

Added them too :P https://github.com/bil-elmoussaoui/Hardcode-Tray/blob/master/database/teamviewer Just don't know how to name the two new icons, can you do that?

@andia89
Copy link
Collaborator

andia89 commented Dec 20, 2015

Done

@bilelmoussaoui
Copy link
Owner Author

Thanks , i've opened a new request in Numix base repo ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants