Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assembly shouldn't run twice #480

Closed
fnothaft opened this issue Nov 16, 2014 · 4 comments · Fixed by #481
Closed

Assembly shouldn't run twice #480

fnothaft opened this issue Nov 16, 2014 · 4 comments · Fixed by #481
Assignees
Labels

Comments

@fnothaft
Copy link
Member

The Maven Assembly plugin right now runs the assembly phase when in package. This causes Assembly to run twice. Instead, we should run the single phase, which only runs once.

For the life of me, I can't tell why assembly runs it twice. @heuermh?

@heuermh
Copy link
Member

heuermh commented Nov 16, 2014

As of version 2.5.1, the maven assembly docs say

"The main goal in the assembly plugin is the single goal. It is used to create all assemblies. All other goals are deprecated and will be removed in a future release."
http://maven.apache.org/plugins/maven-assembly-plugin/

So +1 on #481 from me.

Just watch out for the issue with tar.gz artifacts described here
nmdp-bioinformatics/ngs#78

@fnothaft
Copy link
Member Author

Thanks @heuermh! I haven't seen the tar issue on OS X yet, but I would imagine that is a problem for both the single and assembly goals.

@heuermh
Copy link
Member

heuermh commented Nov 16, 2014

Yep, only happens if you also upgrade to version 2.5.1.

@fnothaft
Copy link
Member Author

OK, gotcha!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants