fix: address chrome cookie SameSite issue

bigcommerce · Mar 24, 2020 · 5938ce1 · 5938ce1
1 parent 5f18c44
commit 5938ce1
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/bin/stencil-start b/bin/stencil-start
@@ -230,6 +230,7 @@ function startServer() {
             },
             proxy: "localhost:" + stencilServerPort,
             tunnel: tunnel,
+            https: Url.parse(staplerUrl).protocol === 'https:'
         });
 
         // Handle manual reloading of browsers by typing 'rs';

diff --git a/server/lib/utils.js b/server/lib/utils.js
@@ -14,7 +14,7 @@ function stripDomainFromCookies(cookies) {
     const fixedCookies = [];
 
     _.forEach(cookies, function(cookie) {
-        fixedCookies.push(cookie.replace(/(?:;\s)?domain=(?:.+?)(;|$)/, '$1'));
+        fixedCookies.push(cookie.replace(/(?:;\s)?domain=(?:.+?)(;|$)/, '$1').replace('; SameSite=none', ''));
     });
 
     return fixedCookies;

diff --git a/server/plugins/renderer/renderer.module.js b/server/plugins/renderer/renderer.module.js
@@ -246,6 +246,10 @@ internals.parseResponse = function (bcAppData, request, response, responseArgs,
                     response: response,
                 }, internals.cacheTTL);
 
+                if (response.headers['set-cookie']) {
+                    response.headers['set-cookie'] = Utils.stripDomainFromCookies(response.headers['set-cookie']);
+                }
+
                 return callback(null, internals.getPencilResponse(data, request, response, configuration));
             });
         }