-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Templating issue: should electrodes.tsv and coordsystem.json writing per eeg/ieeg only have certain entities? #649
Comments
IMHO, "run" does not make sense for EEG electrodes.tsv --> there is typically just one digitization of electrodes per session, just like in iEEG (although in iEEG, it could potentially even be the same for several sessions, which is seldom to never true for EEG). The acquisition entity makes sense to add something like Finally, the |
So eeg: And no need to include extra entities because they just then imply there are multiple coords (when in reality they're all copies of the same file)? Seems like this should produce a warning in the |
I think
where all except "subject" are optional, and "optional" is REQUIRED. It's like that also in the entity table, see: https://bids-specification.readthedocs.io/en/stable/99-appendices/04-entity-table.html#encephalography-eeg-ieeg-and-meg seems like we just failed to update the "templates" in the flow text accordingly. would you be willing to make a PR for that @adam2392? the space for eeg can stay included although I doubt that it'd be used much. As for the validator, it currently accepts all entities for |
Summary
This came up in mne-tools/mne-bids#592
According to the spec: https://bids-specification.readthedocs.io/en/stable/04-modality-specific-files/04-intracranial-electroencephalography.html#electrode-description-_electrodestsv
ieeg can have subject/session/space for electrodes.tsv.
while eeg can have subject/session/acquisition/run for electrodes.tsv (and maybe space?)
https://bids-specification.readthedocs.io/en/stable/04-modality-specific-files/03-electroencephalography.html#electrodes-description-_electrodestsv
Is this correct?
Proposed Solution
My understanding is that you only need one
electrodes.tsv/coordsystem.json
per session directory because all the electrodes/channels are the same "within the same session" for iEEG. So you can have multiple tasks, runs, acquisitions, etc.But I suppose this might be different for say scalp EEG based on reading the above? Either way some clarification would help immensely.
Based on the discussion for the above, I can make a subsequent PR if it is deemed appropriate.
The text was updated successfully, but these errors were encountered: