New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify XXXCoordinateSystem #493

Closed

sappelhoff opened this issue Jun 2, 2020 · 2 comments · Fixed by #520

Assignees

Labels

Member

sappelhoff commented Jun 2, 2020

We talk about XXXCoordinateSystem at several points in the specification, but we never introduce what we mean by that.

The XXX is intended as a wildcard for EEG, MEG, or iEEG.

The specification should contain a brief paragraph to make this clear.

The text was updated successfully, but these errors were encountered:

jclauneuro commented Jun 5, 2020

+1. The Coordinates section needs better examples and the specs still need work. I didn't have time before the freeze to look into this unfortunately. Should we leave this for a future release given the v1.4.0 freeze?

Collaborator

effigies commented Jun 5, 2020

I think this clarification could easily go into a 1.4.1, so delaying for now won't have much impact.

And a PR can be submitted now; it just can't be merged until after the release.

sappelhoff mentioned this issue

[FIX] clarify XXXCoord* in the coordinate systems appendix #520

Merged

sappelhoff added EEG iEEG MEG labels

sappelhoff self-assigned this

sappelhoff closed this as completed in #520

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment