-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
requirement of channels.tsv is not consistent for MEG, EEG and iEEG #344
Comments
+1 (I also had in my mind that _channels.tsv was required) |
agreed, I think that at the minimum it should be SHOULD for all three modalities. I would also agree and argue that it should be MUST for them as well. |
sounds fair to me. |
+1 same for all three modalities |
If we implement SHOULD for all, it would not break compatibility with existing datasets, but only loosen the requirement for MEG. If we implement MUST for all, we have to consider that there could be valid EEG and iEEG datasets out there without channels.tsv. These existing datasets (either in public or private archives) do comply with BIDS v1.2.1 (or whatever number we are at right now). In this case we have to ensure that the validator still considers these older datasets as valid. I actually have no idea whether BIDS versioning is already part of the validator, I don't recall seeing it. Content wise I would prefer MUST, but realize that the amount of work for SHOULD is much more manageable. |
yeah unfortunately it is not :( There isn't a validator for every BIDS version that comes out. hmm ... it's a bit weird that |
I agree, +1 for a consistent SHOULD. |
@bids-standard/raw-electrophys while looking at https://github.com/bids-standard/bids-examples/tree/master/ds000117 I noticed that to my surprise channels.tsv is missing. Subsequently I realized that according to https://bids-specification.readthedocs.io/en/stable/ it is RECOMMENDED for MEG (i.e. it SHOULD be there but it is not required and ds000117 is therefore compliant), whereas for EEG and iEEG it is not specified whether the channels file MUST, SHOULD or MAY be present.
I had in my mind that it MUST be present. I have also been explaining it like that to EEG and iEEG folks (and probably also to MEG folks).
I consider it undesirable that the specification (for EEG and iEEG) is not explicit. Furthermore, I would consider it undesirable that the same file for the three electrophysiology specifications would have different requirements. What is your take on this?
The text was updated successfully, but these errors were encountered: