Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsvwrite writes non-compliant tsvs when a table is provided #603

Closed
coxroy opened this issue Jul 31, 2023 · 1 comment · Fixed by #605
Closed

tsvwrite writes non-compliant tsvs when a table is provided #603

coxroy opened this issue Jul 31, 2023 · 1 comment · Fixed by #605
Labels
bug Something isn't working

Comments

@coxroy
Copy link

coxroy commented Jul 31, 2023

whenever a Matlab table is provided to tsvwrite, Matlab's builtin writetable is used to write the tsv. this can result in noncompliant tsvs if the user did not manually think to change empty/NaN/NaT/etc values to n/a.

possible solution is to call table2struct whenever a table is provided, with this struct then undergoing the already present checks for noncompliant values

@Remi-Gau
Copy link
Collaborator

Can reproduce the bug in dev and in master.
will push a hot fix in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants