Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MEEG+iEEG --> Make it a requirement that channels in bids sidecar and raw file are in order #52

Open
sappelhoff opened this issue Feb 10, 2021 · 3 comments
Labels
EEG iEEG MEG metadata Changes to metadata fields/files.

Comments

@sappelhoff
Copy link
Member

sappelhoff commented Feb 10, 2021

came up in mne-tools/mne-bids#697 (comment)

We currently have the following in the spec:

EEG:

To avoid confusion, the channels SHOULD be listed in the order they appear in the EEG data file.

source

iEEG:

Channels SHOULD appear in the table in the same order they do in the iEEG data file.

source

MEG:

To avoid confusion, the channels SHOULD be listed in the order they appear in the MEG data file.

source

our proposal (cc @hoechenberger @agramfort ) is to turn this "SHOULD" into a "MUST". This would be in line with the BIDS principle to place most burden on the dataset curation stage, as that's a one-time-burden. All steps that follow after this will have an easier time. For example, tools can rely on the sidecar files, and don't have to double check with the raw files.

Potential issue(s):

  • We currently cannot validate a MUST, because we lack JS readers for ephys formats
  • Breaking backwards incompatibility for all currently existing datasets that did not follow the RECOMMENDATION ("SHOULD") that we now want to turn into a REQUIREMENT ("MUST")

Somewhat parallel issue(s):

@hoechenberger
Copy link

+100 on this one.

@agramfort
Copy link

agramfort commented Feb 10, 2021 via email

@sappelhoff sappelhoff transferred this issue from bids-standard/bids-specification Apr 9, 2022
@sappelhoff sappelhoff reopened this Apr 9, 2022
@tsalo tsalo added the metadata Changes to metadata fields/files. label Apr 9, 2022
@agramfort
Copy link

agramfort commented Apr 10, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EEG iEEG MEG metadata Changes to metadata fields/files.
Projects
None yet
Development

No branches or pull requests

4 participants