Remove deprecated suffixes (e.g. FLASH, phase, etc) Was: Change FLASH for non-proprietary name

[tsalo]

FLASH is specific to Siemens. GE calls is SPGR, Philips FFE. I would use an acronym that is not vendor-specific, e.g. SGRE (for spoiled gradient echo), or simply GRE (and the information about spoiler could be added in the descriptive fields).

Original authors: @jcohenadad

[tsalo]

@chrisgorgo wrote:

I wonder this could be incorporated in BIDS 1.x instead of waiting for 2.0 since it does not seem to require any backward incompatible changes. The way to do it is to draft a BIDS Extension Proposal similar to one of those: https://docs.google.com/document/d/1HFUkAEE-pB-angVcYe6pf_-fVf4sCpOHKesUvfb8Grc/edit#heading=h.18rh5sozhnxy

[tsalo]

FLASH is listed as a semi-deprecated ("legacy") suffix in BEP001 (bids-standard/bids-specification#508). If that is merged, I will close this.

[yarikoptic]

indeed they are now listed as deprecated (did not spot changelog entry) in https://bids-specification.readthedocs.io/en/stable/modality-specific-files/magnetic-resonance-imaging-data.html#deprecated-suffixes

so we should just really deprecate / remove them.

[yarikoptic]

❯ git grep deprecated src/schema/rules/files/
src/schema/rules/files/raw/anat.yaml:    - T2star # deprecated
src/schema/rules/files/raw/anat.yaml:    - FLASH # deprecated
src/schema/rules/files/raw/anat.yaml:    - PD # deprecated
src/schema/rules/files/raw/func.yaml:    - phase # deprecated