Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPM example #34

Closed
tiborauer opened this issue Mar 26, 2019 · 8 comments
Closed

MPM example #34

tiborauer opened this issue Mar 26, 2019 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@tiborauer
Copy link
Collaborator

tiborauer commented Mar 26, 2019

Regarding the examples, the current version contains a template
sub-<participant_label>[_ses-<session_label>][_<indexable_metadata>-<index>][_acq-<label>][_part-<mag/phase>][_ce-<label>][_rec-<label>][_run-<index>]_<suffix>.nii.gz,
so the MPM example should be:

  • sub-01_echo-1_acq-MTon_part-mag_MPM.nii.gz
  • sub-01_echo-1_acq-MToff_part-mag_MPM.nii.gz
  • sub-01_echo-1_acq-T1w_part-mag_MPM.nii.gz
    (i.e. "acq" before "part")
@agahkarakuzu
Copy link
Collaborator

Please see this branch, where I changed file names. Remaining steps:

  • Collapse sub-01_acq-MToff_MPM, sub-01_acq-MTon_MPM and sub-01_acq-T1w_MPM json files into one file called sub-01_MPM.json.
  • Edit json files with respect to the changes.

@tiborauer
Copy link
Collaborator Author

AFAICS, the images in the MPM folder still follows the previous order:
E.g.:

  • sub-01_echo-1_part-mag_acq-MToff_MPM.nii.gz (i.e. "part" before "acq")

@agahkarakuzu
Copy link
Collaborator

agahkarakuzu commented Apr 10, 2019

@tiborauer thanks for the heads up, you're right. I will correct them as I edit json files.

        sub-<participant_label>[_ses-<session_label>][_<indexable_metadata>-<index>][_acq-<label>][_part-<mag/phase>][_ce-<label>][_rec-<label>][_run-<index>]_<suffix>.nii[.gz]

@lazaral
Copy link
Collaborator

lazaral commented Apr 11, 2019

@agahkarakuzu thank you for nice fixes on the MPM example!

I'll start working on that branch as well to create the 'derivatives' folder - happy to help with the json files as well if useful, or I can give it a quick proof-read afterwards. I had a quick look now and noticed a small spelling mistake in the third PDw echo json where it says 'of' rather than 'off', but it's probably not worth correcting now as it will get changed again?

@agahkarakuzu
Copy link
Collaborator

I'll start working on that branch as well to create the 'derivatives' folder

Thanks for #38 :)

happy to help with the json files as well if useful, or I can give it a quick proof-read afterwards.

Thank you, feel free to work on it as you like!

Regarding json files, the root json file (sub-01_suffix.json) should be containing some extra metadata fields (e.g. vendor and sequence specific tags). At least, this was the idea in the gdoc. Should we include this in the example datasets as well? @Gilles86 @KirstieJane maybe we can discuss this in the next meeting.

@KirstieJane
Copy link
Member

KirstieJane commented Apr 15, 2019

Hey folks - in #22 I think we're not following the derivatives proposal accurately.... (Here's the proposal: https://github.com/bids-standard/bids-specification/blob/derivatives/src/05-derivatives/01-introduction.md)

We should have a pipeline name for each of the derived folders, right?

I might be totally missing the mark here.... 😬

UPDATE - I've made an hmri pipeline folder in the PR to @lazaral's branch (lazaral#1)

@KirstieJane
Copy link
Member

This is related to #46

@KirstieJane KirstieJane added the enhancement New feature or request label May 15, 2019
@lazaral
Copy link
Collaborator

lazaral commented May 28, 2019

I fixed some of these issues in #38 - hopefully it is fairly up to date now, let me know if there's anything more I should change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants