Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize proposal submission #57

Open
7 tasks
cmaumet opened this issue Jun 15, 2021 · 4 comments
Open
7 tasks

Finalize proposal submission #57

cmaumet opened this issue Jun 15, 2021 · 4 comments

Comments

@cmaumet
Copy link
Collaborator

cmaumet commented Jun 15, 2021

  • First pass at updating the BEP028 spec to be compliant with latest discussions.

Add a usage examples of this spec for the following:

  • 1- simplest model with one activity and its parameters,
  • 2- workflow with more than 1 activity,
  • 3- encoding environement (Matlab, docker, bash, etc.).
  • 4- an example with hierarchies of activities (use isPartOf form PROVONE)
  • 5- an example that uses the ontology of processings / image types
  • 6- an example discussing file-level prov VS dataset-level prov
@remiadon
Copy link
Contributor

remiadon commented Jun 16, 2021

@cmaumet I just updated the document, mainly to

  1. update the examples (json-ld files structure and content)
  2. discuss about dataset-level representation (global sidecar file) VS file-level representation (one sidecar file per datafile)

IMO point 2 is not really to be discussed, as we strive for a global sidecar file in most cases, and even allow definitions to be shared across multiple files.

Should would start a separate thread to add more examples and usecases for beta users of BIDS-prov ??
There is a running issue that may be suited for this, here #56

@remiadon
Copy link
Contributor

TODO : add this field to the common definition, just after @context

"BIDSProvVersion": "1.0.0",

@cmaumet
Copy link
Collaborator Author

cmaumet commented Jun 18, 2021

@remiadon: you can implement the changes to the examples (version) directly in your PR #58.

@remiadon
Copy link
Contributor

remiadon commented Jun 18, 2021

@cmaumet done in 47fb0a9

BTW is there a way to define a common header for all sides car files ??
Just adding "BIDSProvVersion": "1.0.0", got me going into editing all the .json files in our repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants