Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor uiGroupHandlers #1334

Open
sprunk opened this issue Feb 29, 2024 · 0 comments
Open

Refactor uiGroupHandlers #1334

sprunk opened this issue Feb 29, 2024 · 0 comments
Labels
good first issue Good for newcomers refactor Internal code cleanup; paying off technical debt; janitorial work.

Comments

@sprunk
Copy link
Collaborator

sprunk commented Feb 29, 2024

Right now this is an array of group handlers indexed by teamID. There's two broad users, one is the skirmish AI interface which indexes it with given AI's team, and the rest is most of the player-facing UI which indexes it with gu->myTeam.

Change this into one standalone grouphandler for the player UI (everywhere it's gu->myTeam currently) and have the array indexed by AI ID. This way player units won't lose group when changing teams (capture, dynamic comshare) and players/AIs that happen to be on the same team won't interfere with each other's groups.

Somewhat related: #1099

@sprunk sprunk added the good first issue Good for newcomers label Feb 29, 2024
@sprunk sprunk added the refactor Internal code cleanup; paying off technical debt; janitorial work. label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers refactor Internal code cleanup; paying off technical debt; janitorial work.
Projects
None yet
Development

No branches or pull requests

1 participant