Skip to content

Commit

Permalink
ci: Use Ubuntu 22.04 runner for run-examples, run-examples-on-wasm jo…
Browse files Browse the repository at this point in the history
…bs (#6875)

# Objective

- The `run-examples-on-wasm` job fails on Ubuntu 22.04, when it was previously working on Ubuntu 20.04. Playwright 1.22.1 (the version currently pinned by us) fails trying to install system dependencies that were renamed between Ubuntu 20.04 and 22.04.
- The `run-examples` job previously failed on Ubuntu 22.04 with errors consistent with those listed in [this upstream mesa bug](https://gitlab.freedesktop.org/mesa/mesa/-/issues/7819).
- Fixes #6832

## Solution

- Upgrade `playwright` to the latest [v1.28.1](https://github.com/microsoft/playwright/releases/tag/v1.28.1) release. Ubuntu 22.04 support was [added](microsoft/playwright#14588) in [v1.23.0](https://github.com/microsoft/playwright/releases/tag/v1.23.0). The [test now passes on 22.04](https://github.com/oliviacrain/bevy/actions/runs/3633583112/jobs/6130757397), and the output screenshots are unchanged from previous job outputs.
- Use `ubuntu-latest` for the `run-examples` job. No other modifications necessary. The [PPA we pull mesa from](https://launchpad.net/~oibaf/+archive/ubuntu/graphics-drivers) rebuilt the package for 22.04 with the [upstream fix](https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20145/diffs?commit_id=b3d1ae19f2f4d93cf0a5f45a598149ac4e8e05aa).
  • Loading branch information
oliviacrain committed Dec 8, 2022
1 parent 8eedc8f commit b58ca87
Show file tree
Hide file tree
Showing 4 changed files with 32 additions and 18 deletions.
44 changes: 29 additions & 15 deletions .github/start-wasm-example/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/start-wasm-example/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"author": "",
"license": "ISC",
"devDependencies": {
"@playwright/test": "^1.22.1"
"@playwright/test": "^1.28.1"
},
"dependencies": {
"dotenv": "^16.0.1"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ jobs:
#GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

run-examples:
runs-on: ubuntu-20.04 # TODO: figure out why latest fails
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- name: Install Bevy dependencies
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/validation-jobs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ jobs:
done
run-examples-on-wasm:
runs-on: ubuntu-20.04 # TODO: figure out why this fails on latest
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
- uses: actions/checkout@v3
Expand Down

0 comments on commit b58ca87

Please sign in to comment.