Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.13 to 0.14 migration guide didn't mention insert_gizmo_group #1551

Closed
onelson opened this issue Jul 12, 2024 · 3 comments · Fixed by #1575
Closed

0.13 to 0.14 migration guide didn't mention insert_gizmo_group #1551

onelson opened this issue Jul 12, 2024 · 3 comments · Fixed by #1575

Comments

@onelson
Copy link

onelson commented Jul 12, 2024

Just finished migrating a project to 0.14 🥳

Formerly I was calling insert_gizmo_group when building my app to configure gizmos for bevy_xpbd but now needed to use insert_gizmo_config.

I didn't see any mention of in the migration guide (this was the only thing I had to chase down myself instead of referring to what was in the guide).

@TrialDragon
Copy link
Member

TrialDragon commented Jul 12, 2024

Good catch! It seems bevyengine/bevy#10973 wasn't marked properly as having breaking changes and as such didn't have a migration guide / this change wasn't even mentioned in the PRs changelong nor comments from what I can see.

I wonder if there are other breaking changes in that PR, hmm.

(Off-topic, I wonder why only insert_gizmo_group / insert_gizmo_config was changed and not also init_gizmo_group since they seemed to be following same naming convention before this change; feels inconsistent now).

@BD103
Copy link
Member

BD103 commented Jul 12, 2024

(Off-topic, I wonder why only insert_gizmo_group / insert_gizmo_config was changed and not also init_gizmo_group since they seemed to be following same naming convention before this change; feels inconsistent now).

@Aceeri, would you be able to comment on this?

@BD103 BD103 added this to the Release v0.14 milestone Jul 12, 2024
@Aceeri
Copy link
Member

Aceeri commented Jul 12, 2024

(Off-topic, I wonder why only insert_gizmo_group / insert_gizmo_config was changed and not also init_gizmo_group since they seemed to be following same naming convention before this change; feels inconsistent now).

@Aceeri, would you be able to comment on this?

Been a bit, but I don't super remember why I didn't rename both. I think it had something to do with how they were separated before but doing the same thing internally? I do remember thinking group just didn't fit the name very well for what it does, but I yeah we should rename them to have the same suffix for both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants